Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336763003: remove path specific program building classes (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pathgp
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove path specific program building classes BUG=skia: Committed: https://skia.googlesource.com/skia/+/d8dd47b5fa52430a1ab5c07335c0c13fcd43a82d

Patch Set 1 #

Patch Set 2 : rebase onto origin/master #

Patch Set 3 : tweaks #

Total comments: 1

Patch Set 4 : a few more tidys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -386 lines) Patch
M gyp/gpu.gypi View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPathProcessor.h View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLPathProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/gl/GrGLPathProgram.h View 1 chunk +0 lines, -49 lines 0 comments Download
D src/gpu/gl/GrGLPathProgram.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
D src/gpu/gl/GrGLPathProgramDataManager.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/gpu/gl/GrGLPathProgramDataManager.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 5 chunks +9 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 5 chunks +19 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 1 2 3 3 chunks +26 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 3 chunks +37 lines, -2 lines 0 comments Download
D src/gpu/gl/builders/GrGLPathProgramBuilder.h View 1 chunk +0 lines, -32 lines 0 comments Download
D src/gpu/gl/builders/GrGLPathProgramBuilder.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 8 chunks +46 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 3 months ago (2015-09-11 17:09:46 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1336763003/diff/40001/src/gpu/gl/GrGLProgramDataManager.h File src/gpu/gl/GrGLProgramDataManager.h (right): https://codereview.chromium.org/1336763003/diff/40001/src/gpu/gl/GrGLProgramDataManager.h#newcode56 src/gpu/gl/GrGLProgramDataManager.h:56: extra \n
5 years, 3 months ago (2015-09-11 18:32:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763003/60001
5 years, 3 months ago (2015-09-11 18:39:22 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 18:45:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d8dd47b5fa52430a1ab5c07335c0c13fcd43a82d

Powered by Google App Engine
This is Rietveld 408576698