Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1336703002: Revert of Re-land: cc: Use worker context for one-copy tile initialization. (Closed)

Created:
5 years, 3 months ago by Eric Caruso
Modified:
5 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, sunnyps, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: cc: Use worker context for one-copy tile initialization. (patchset #33 id:630001 of https://codereview.chromium.org/1230203007/ ) Reason for revert: This CL is responsible for issue 525811. Pixel 2015 gets strange artifacts across suspend/resume that only go away when you reboot. Original issue's description: > Re-land: cc: Use worker context for one-copy tile initialization. > > This moves management of staging resources to > OneCopyTileTaskWorkerPool class. This makes it possible > to use a worker context to issue and detect when copy > operations complete. > > BUG=490295 > TBR=jamesr@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/91d23278a61f82e03bf4bac2a5c509579a57edd0 > Cr-Commit-Position: refs/heads/master@{#344490} TBR=jamesr@chromium.org,kbr@chromium.org,piman@chromium.org,primiano@chromium.org,sky@chromium.org,vmiura@chromium.org,vmpstr@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+848 lines, -793 lines) Patch
M cc/output/context_provider.h View 2 chunks +0 lines, -22 lines 0 comments Download
M cc/output/output_surface.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 5 chunks +60 lines, -63 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 11 chunks +340 lines, -495 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M cc/resources/resource_format.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/resources/resource_format.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M cc/resources/resource_pool.h View 1 chunk +4 lines, -1 line 0 comments Download
M cc/resources/resource_pool.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/resources/resource_pool_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M cc/resources/resource_provider.h View 7 chunks +15 lines, -3 lines 0 comments Download
M cc/resources/resource_provider.cc View 10 chunks +153 lines, -3 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 25 chunks +109 lines, -25 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/surfaces/surface_display_output_surface_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_output_surface.h View 1 chunk +3 lines, -5 lines 0 comments Download
M cc/test/fake_resource_provider.h View 4 chunks +4 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 6 chunks +21 lines, -6 lines 0 comments Download
M cc/test/layer_tree_pixel_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M cc/test/pixel_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 11 chunks +33 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 5 chunks +7 lines, -30 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_metrics.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_metrics.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Eric Caruso
Created Revert of Re-land: cc: Use worker context for one-copy tile initialization.
5 years, 3 months ago (2015-09-10 21:10:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336703002/1
5 years, 3 months ago (2015-09-10 21:11:38 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-10 21:11:39 UTC) #4
Ken Russell (switch to Gerrit)
While Chromium's policy is certainly to revert CLs that caused breakage, this one landed 3 ...
5 years, 3 months ago (2015-09-10 21:28:51 UTC) #5
reveman
On 2015/09/10 at 21:28:51, kbr wrote: > While Chromium's policy is certainly to revert CLs ...
5 years, 3 months ago (2015-09-11 13:17:48 UTC) #6
Primiano Tucci (use gerrit)
Can this be closed? Keeps showing on rietveld and I think the chances that this ...
5 years, 2 months ago (2015-10-06 16:07:58 UTC) #7
Primiano Tucci (use gerrit)
Can this be closed? Keeps showing on rietveld and I think the chances that this ...
5 years, 2 months ago (2015-10-06 16:07:59 UTC) #8
Eric Caruso
5 years, 2 months ago (2015-10-06 17:25:43 UTC) #9
Message was sent while issue was closed.
On 2015/10/06 16:07:59, Primiano Tucci wrote:
> Can this be closed? Keeps showing on rietveld and I think the chances that
this
> would apply cleanly after ~4 weeks are nearly zero.

Done.

Powered by Google App Engine
This is Rietveld 408576698