Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1186393004: gpu: Remove async texture uploads. (Closed)

Created:
5 years, 6 months ago by reveman
Modified:
5 years, 3 months ago
Reviewers:
sky, vmpstr, no sievers
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, David Yen, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, piman, qsr+mojo_chromium.org, sievers+watch_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove async texture uploads. This removes the usage of async texture uploads from cc/ and all support for it from the GPU service. Follow up changes will provide significant cleanup and some performance improvements in cc/ as a result of this. BUG=499372 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c2dd691c2c8485a74ba0606c87db650b00d0b904 Cr-Commit-Position: refs/heads/master@{#345908}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase fixes #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : address feedback and remove more one-copy flags #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -6731 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D cc/raster/pixel_buffer_tile_task_worker_pool.h View 1 2 1 chunk +0 lines, -146 lines 0 comments Download
D cc/raster/pixel_buffer_tile_task_worker_pool.cc View 1 2 1 chunk +0 lines, -755 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 1 2 3 5 chunks +6 lines, -19 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 2 3 5 chunks +6 lines, -46 lines 0 comments Download
M cc/resources/resource_provider.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 9 chunks +4 lines, -222 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 2 2 chunks +0 lines, -142 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.h View 1 2 3 3 chunks +9 lines, -16 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 1 2 3 5 chunks +0 lines, -18 lines 0 comments Download
M cc/test/test_gles2_interface.h View 2 chunks +0 lines, -19 lines 0 comments Download
M cc/test/test_gles2_interface.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 chunks +8 lines, -52 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_blending.cc View 1 2 15 chunks +19 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_synchronous.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 chunks +0 lines, -55 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 2 3 4 2 chunks +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 1 chunk +0 lines, -21 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 5 2 chunks +0 lines, -46 lines 0 comments Download
M gpu/command_buffer/client/buffer_tracker_unittest.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator.h View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator.cc View 1 2 3 2 chunks +2 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 1 2 3 4 chunks +1 line, -66 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 chunks +0 lines, -48 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 2 chunks +0 lines, -38 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 9 chunks +2 lines, -243 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory.h View 1 2 3 3 chunks +1 line, -4 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory.cc View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 1 2 3 7 chunks +6 lines, -68 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/query_tracker_unittest.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 1 chunk +0 lines, -281 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 1 chunk +25 lines, -29 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 3 4 5 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 3 2 chunks +0 lines, -23 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate.h View 1 chunk +0 lines, -117 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_mock.h View 1 chunk +0 lines, -39 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_mock.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager.h View 1 chunk +0 lines, -110 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_android.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_egl.h View 1 chunk +0 lines, -58 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 1 1 chunk +0 lines, -733 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_idle.h View 1 chunk +0 lines, -70 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_linux.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_mac.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_mock.h View 1 chunk +0 lines, -39 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_mock.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_share_group.h View 1 chunk +0 lines, -60 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 1 chunk +0 lines, -549 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_stub.h View 1 chunk +0 lines, -39 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_stub.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_sync.h View 1 chunk +0 lines, -50 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_sync.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_manager_win.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 16 chunks +3 lines, -403 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
D gpu/command_buffer/service/gles2_cmd_decoder_unittest_async_pixel.cc View 1 chunk +0 lines, -388 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 3 chunks +1 line, -137 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/tests/gl_virtual_contexts_unittest.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 chunks +0 lines, -22 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_enums_implementation_autogen.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
reveman
5 years, 3 months ago (2015-08-26 15:51:42 UTC) #2
no sievers
LGTM with 2 comments. Can you also remove GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM from gl_bindings.h? https://codereview.chromium.org/1186393004/diff/60001/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (left): ...
5 years, 3 months ago (2015-08-26 18:37:27 UTC) #3
reveman
On 2015/08/26 at 18:37:27, sievers wrote: > LGTM with 2 comments. > > Can you ...
5 years, 3 months ago (2015-08-26 22:34:25 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1186393004/80001
5 years, 3 months ago (2015-08-26 22:35:25 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/76211) linux_chromium_compile_dbg_32_ng on ...
5 years, 3 months ago (2015-08-26 22:40:22 UTC) #8
reveman
+sky for components/view_manager/, mojo/, chrome/
5 years, 3 months ago (2015-08-26 22:41:03 UTC) #10
reveman
fyi, --shortstat: 119 files changed, 105 insertions(+), 6731 deletions(-)
5 years, 3 months ago (2015-08-26 22:45:48 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1186393004/100001
5 years, 3 months ago (2015-08-26 22:45:58 UTC) #13
sky
LGTM
5 years, 3 months ago (2015-08-26 23:21:46 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 00:17:02 UTC) #16
vmpstr
lgtm
5 years, 3 months ago (2015-08-27 17:18:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1186393004/100001
5 years, 3 months ago (2015-08-27 17:19:32 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-08-27 17:26:05 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:26:58 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c2dd691c2c8485a74ba0606c87db650b00d0b904
Cr-Commit-Position: refs/heads/master@{#345908}

Powered by Google App Engine
This is Rietveld 408576698