Issue 133073009: Move GrGLInterface function pointers into a nested struct

Issue 133073009: Move GrGLInterface function pointers into a nested struct (Closed)

Created:
6 years, 11 months ago by bsalomon

Modified:
6 years, 11 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Move GrGLInterface function pointers into a nested struct BUG=skia:2042 Committed: http://code.google.com/p/skia/source/detail?r=13130

Patch Set 3 : Rob's comments #

Patch Set 4 : upload again, rietveld diff failed. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1573 lines, -1169 lines)			Patch
include/gpu/gl/GrGLExtensions.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
include/gpu/gl/GrGLInterface.h	View	1 2	2 chunks	+422 lines, -215 lines	0 comments	Download
include/gpu/gl/SkGLContextHelper.h	View		1 chunk	+6 lines, -6 lines	0 comments	Download
src/gpu/gl/GrGLContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
src/gpu/gl/GrGLCreateNullInterface.cpp	View		1 chunk	+136 lines, -133 lines	0 comments	Download
src/gpu/gl/GrGLInterface.cpp	View	1	9 chunks	+387 lines, -199 lines	0 comments	Download
src/gpu/gl/GrGLUniformManager.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
src/gpu/gl/GrGLUtil.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
src/gpu/gl/GrGLUtil.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp	View		2 chunks	+305 lines, -303 lines	0 comments	Download
src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp	View		6 chunks	+9 lines, -7 lines	0 comments	Download
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp	View		1 chunk	+135 lines, -133 lines	0 comments	Download
src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp	View		1 chunk	+110 lines, -110 lines	0 comments	Download
src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp	View		5 chunks	+47 lines, -46 lines	0 comments	Download
src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp	View		1 chunk	+3 lines, -4 lines	0 comments	Download
src/views/win/SkOSWindow_win.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm https://codereview.chromium.org/133073009/diff/30001/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (right): https://codereview.chromium.org/133073009/diff/30001/include/gpu/gl/GrGLInterface.h#newcode102 include/gpu/gl/GrGLInterface.h:102: GLPtrAlias(GLPtr<FNPTR_TYPE>* base) : fBase(base) {} rm space between ...

6 years, 11 months ago (2014-01-21 15:38:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/133073009/100001

6 years, 11 months ago (2014-01-21 15:57:30 UTC) #3

bsalomon

https://codereview.chromium.org/133073009/diff/30001/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (right): https://codereview.chromium.org/133073009/diff/30001/include/gpu/gl/GrGLInterface.h#newcode102 include/gpu/gl/GrGLInterface.h:102: GLPtrAlias(GLPtr<FNPTR_TYPE>* base) : fBase(base) {} On 2014/01/21 15:38:05, robertphillips ...

6 years, 11 months ago (2014-01-21 16:04:54 UTC) #4

Message was sent while issue was closed.

Change committed as 13130

Expand Messages | Collapse Messages