Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1324903002: [Background Sync] Remove out-of-date layout test (Closed)

Created:
5 years, 3 months ago by iclelland
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Background Sync] Remove out-of-date layout test Uncontrolled window clients should now be allowed to register one-shot background sync events, as long as they have a registered service worker. This patch removes the old test (which expected exactly the opposite behaviour.) Part 3 changes the behaviour in Chromium, and a new layout test for the correct behaviour is added in part 4. This is part 2 of a now-four-part blink-chromium-blink dance. Part 1: https://codereview.chromium.org/1309393003 Part 2: https://codereview.chromium.org/1324903002 (this patch) Part 3: https://codereview.chromium.org/1316743002 Part 4: https://codereview.chromium.org/1314453003 BUG=5188884 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201561

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M LayoutTests/http/tests/background_sync/oneshot.html View 1 1 chunk +6 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
iclelland
jkarlin: FYI; hopefully no action required :) mlamouri: Can you take a quick look? The ...
5 years, 3 months ago (2015-09-01 14:20:05 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 3 months ago (2015-09-01 14:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324903002/20001
5 years, 3 months ago (2015-09-01 14:27:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/106455)
5 years, 3 months ago (2015-09-01 15:27:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324903002/20001
5 years, 3 months ago (2015-09-01 15:29:47 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 16:11:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201561

Powered by Google App Engine
This is Rietveld 408576698