Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1309393003: [Background Sync] Allow sync manager access from uncontrolled clients (Closed)

Created:
5 years, 4 months ago by iclelland
Modified:
5 years, 3 months ago
Reviewers:
jkarlin
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Background Sync] Allow sync manager access from uncontrolled clients This patch removes the requirement for the caller of a BackgroundSync manager method to be either a service worker or a controlled client. Now, uncontrolled clients are also able to access the manager, and Blink informs the browser whether a registration request came from a Service Worker or not. (Service Workers are still required to have at least one active window client in order to register sync events; this is enforced in the browser). This is part 1 of a three-part blink-chromium-blink dance. Part 1: https://codereview.chromium.org/1309393003 (this patch) Part 2: https://codereview.chromium.org/1316743002 Part 3: https://codereview.chromium.org/1314453003 BUG=518884 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201230

Patch Set 1 #

Patch Set 2 : Provide a body for deprecated method in preparation for removing it from subclasses #

Total comments: 2

Patch Set 3 : Fixing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -35 lines) Patch
M Source/modules/background_sync/PeriodicSyncManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/background_sync/PeriodicSyncManager.cpp View 4 chunks +2 lines, -14 lines 0 comments Download
M Source/modules/background_sync/PeriodicSyncManager.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/background_sync/SyncManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/background_sync/SyncManager.cpp View 4 chunks +2 lines, -14 lines 0 comments Download
M Source/modules/background_sync/SyncManager.idl View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/modules/background_sync/WebSyncProvider.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
iclelland
jkarlin: PTAL, thanks!
5 years, 4 months ago (2015-08-25 18:46:15 UTC) #2
jkarlin
lgtm with nit https://codereview.chromium.org/1309393003/diff/20001/public/platform/modules/background_sync/WebSyncProvider.h File public/platform/modules/background_sync/WebSyncProvider.h (right): https://codereview.chromium.org/1309393003/diff/20001/public/platform/modules/background_sync/WebSyncProvider.h#newcode38 public/platform/modules/background_sync/WebSyncProvider.h:38: // TODO(iclelland): Remove this deprecated method ...
5 years, 3 months ago (2015-08-26 12:45:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309393003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309393003/40001
5 years, 3 months ago (2015-08-26 12:54:19 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201230
5 years, 3 months ago (2015-08-26 14:17:54 UTC) #7
iclelland
5 years, 3 months ago (2015-09-02 17:10:37 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1309393003/diff/20001/public/platform/modules...
File public/platform/modules/background_sync/WebSyncProvider.h (right):

https://codereview.chromium.org/1309393003/diff/20001/public/platform/modules...
public/platform/modules/background_sync/WebSyncProvider.h:38: //
TODO(iclelland): Remove this deprecated method once callers have switched to the
4-argument version.
On 2015/08/26 12:45:41, jkarlin wrote:
> The callers have already switched in this case. Perhaps rephrase to "once the
> browser implements the 4-argument version".

That is, of course, absolutely correct :) Thanks; done.

Powered by Google App Engine
This is Rietveld 408576698