Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: LayoutTests/http/tests/background_sync/oneshot.html

Issue 1324903002: [Background Sync] Remove out-of-date layout test (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix typo Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/background_sync/oneshot.html
diff --git a/LayoutTests/http/tests/background_sync/oneshot.html b/LayoutTests/http/tests/background_sync/oneshot.html
index 4f6211c597caec292158e333382c94ec0b68721a..fd8f698ab06d77ce7ec838519b1dcd1a44ee2ed2 100644
--- a/LayoutTests/http/tests/background_sync/oneshot.html
+++ b/LayoutTests/http/tests/background_sync/oneshot.html
@@ -51,32 +51,10 @@ promise_test(function(t) {
}, 'Background Sync API should allow one-shot syncs to be registered from ' +
'the Document scope');
-promise_test(function(t) {
- var url = 'resources/empty_worker.js';
- var scope = 'resources/scope/background_sync/oneshot-uncontrolled.html';
- var sync_manager;
- var sync_registration;
-
- // One-shot syncs can only be registered from a controlled document. This
- // test creates a frame, after the service worker is active, in order to use
- // its service worker registration.
- return service_worker_unregister_and_register(t, url, scope)
- .then(function(sw_registration) {
- sync_manager = sw_registration.sync;
- return wait_for_state(t, sw_registration.installing, 'activated');
- })
- .then(function() { return clear_registered_syncs(sync_manager); })
- .then(function() { return sync_manager.getRegistrations(); })
- .then(function(registrations) {
- assert_equals(registrations.length, 0, 'One-shot syncs should be ' +
- 'cleared at the start of the test.');
- return assert_promise_rejects(
- sync_manager.register({tag: 'should fail'}),
- 'InvalidAccessError',
- 'Should throw with message "Cannot register a sync event without ' +
- 'a window client."');
- })
- .then(function() { return service_worker_unregister(t, scope); })
- }, 'Background Sync API should not allow one-shot syncs to be registered ' +
- 'without window clients controlled by service worker');
+// The test which verified that uncontrolled window clients could not register
+// sync events is out-of-date, and so has been removed. Uncontrolled window
+// clients should be allowed to register sync events, as long as they have a
+// registered service worker.
+// TODO(iclelland): Add a test which verifies the correct behaviour, as per
+// crbug/518884
</script>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698