[Background Sync] Allow sync manager access from uncontrolled clients

[Background Sync] Allow sync manager access from uncontrolled clients

This patch cleans up the method which was deprecated in part 1, and
whose implementations were removed in part 2.

This is part 4 of a four-part blink-chromium-blink dance.
Part 1: https://codereview.chromium.org/1309393003
Part 2: https://codereview.chromium.org/1324903002
Part 3: https://codereview.chromium.org/1316743002
Part 4: https://codereview.chromium.org/1314453003 (this patch)

BUG=518884
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201606

[iclelland, 2015-08-25 18:44:47]

iclelland@chromium.org changed reviewers:
+ jkarlin@chromium.org

[iclelland, 2015-08-25 18:46:33]

jkarlin: PTAL, thanks!

[jkarlin, 2015-08-26 12:59:42]

lgtm

[iclelland, 2015-08-31 23:59:51]

It looks like the layout tests were failing after part 2 was committed (the
Chromium side). I've reversed the sense of the test, so that it expects the
registration from an uncontrolled client to succeed now.

[iclelland, 2015-09-01 02:32:46]

iclelland@chromium.org changed reviewers:
+ jsbell@chromium.org

[iclelland, 2015-09-01 02:35:07]

+r jsbell -- jkarlin is away for a couple more days; could you take a quick look
at the change to the test, for sanity's sake, before I commit this?

(The chromium changes in https://codereview.chromium.org/1316743002/ are causing
the layout tests to fail, since the expected failure is now an expected success;
this change should get the tests passing properly again.)

Thanks!

[jsbell, 2015-09-01 16:25:08]

lgtm

https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/background_sync/oneshot.html (right):

https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/background_sync/oneshot.html:82: return
service_worker_unregister(t, scope);
Just a sanity check since I haven't been following the design of background sync
closely: Will the unregister here ensure that the registered one-shot sync will
never fire? 

(I just want to make sure this won't cause spurious syncs in later tests, since
the test runner's state isn't completely cleared between tests.)

[iclelland, 2015-09-01 16:57:50]

https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/background_sync/oneshot.html (right):

https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/background_sync/oneshot.html:82: return
service_worker_unregister(t, scope);
On 2015/09/01 16:25:08, jsbell wrote:
> Just a sanity check since I haven't been following the design of background
sync
> closely: Will the unregister here ensure that the registered one-shot sync
will
> never fire? 
> 
> (I just want to make sure this won't cause spurious syncs in later tests,
since
> the test runner's state isn't completely cleared between tests.)

Yes, the BackgroundSyncManager is a ServiceWorkerContextObserver, and it will
clear all registered syncs from its in-memory mapping when the service worker
registration is removed.

[iclelland, 2015-09-02 02:34:55]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2015-09-02 02:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/1314453003/#ps40001
(title: "Rebase against dependency patchset")

[commit-bot: I haz the power, 2015-09-02 02:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314453003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314453003/40001

[commit-bot: I haz the power, 2015-09-02 03:16:15]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201606