Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1314453003: [Background Sync] Allow sync manager access from uncontrolled clients (Closed)

Created:
5 years, 3 months ago by iclelland
Modified:
5 years, 3 months ago
Reviewers:
jkarlin, jsbell
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@uncontrolled-windows
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Background Sync] Allow sync manager access from uncontrolled clients This patch cleans up the method which was deprecated in part 1, and whose implementations were removed in part 2. This is part 4 of a four-part blink-chromium-blink dance. Part 1: https://codereview.chromium.org/1309393003 Part 2: https://codereview.chromium.org/1324903002 Part 3: https://codereview.chromium.org/1316743002 Part 4: https://codereview.chromium.org/1314453003 (this patch) BUG=518884 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201606

Patch Set 1 #

Patch Set 2 : Fix layout test associated with this change #

Patch Set 3 : Rebase against dependency patchset #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M LayoutTests/http/tests/background_sync/oneshot.html View 1 2 1 chunk +33 lines, -6 lines 2 comments Download
M public/platform/modules/background_sync/WebSyncProvider.h View 1 1 chunk +1 line, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
iclelland
jkarlin: PTAL, thanks!
5 years, 3 months ago (2015-08-25 18:46:33 UTC) #2
jkarlin
lgtm
5 years, 3 months ago (2015-08-26 12:59:42 UTC) #3
iclelland
It looks like the layout tests were failing after part 2 was committed (the Chromium ...
5 years, 3 months ago (2015-08-31 23:59:51 UTC) #4
iclelland
+r jsbell -- jkarlin is away for a couple more days; could you take a ...
5 years, 3 months ago (2015-09-01 02:35:07 UTC) #6
jsbell
lgtm https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/background_sync/oneshot.html File LayoutTests/http/tests/background_sync/oneshot.html (right): https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/background_sync/oneshot.html#newcode82 LayoutTests/http/tests/background_sync/oneshot.html:82: return service_worker_unregister(t, scope); Just a sanity check since ...
5 years, 3 months ago (2015-09-01 16:25:08 UTC) #7
iclelland
https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/background_sync/oneshot.html File LayoutTests/http/tests/background_sync/oneshot.html (right): https://codereview.chromium.org/1314453003/diff/40001/LayoutTests/http/tests/background_sync/oneshot.html#newcode82 LayoutTests/http/tests/background_sync/oneshot.html:82: return service_worker_unregister(t, scope); On 2015/09/01 16:25:08, jsbell wrote: > ...
5 years, 3 months ago (2015-09-01 16:57:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314453003/40001
5 years, 3 months ago (2015-09-02 02:35:13 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 03:16:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201606

Powered by Google App Engine
This is Rietveld 408576698