Chromium Code Reviews Chromium Code Reviews
Issue 1323133002:
Pass a BubbleReference to BubbleUI::Show. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef COMPONENTS_BUBBLE_BUBBLE_UI_H_ | 5 #ifndef COMPONENTS_BUBBLE_BUBBLE_UI_H_ |
| 6 #define COMPONENTS_BUBBLE_BUBBLE_UI_H_ | 6 #define COMPONENTS_BUBBLE_BUBBLE_UI_H_ |
| 7 | 7 |
| 8 #include "components/bubble/bubble_reference.h" | |
| 9 | |
| 8 class BubbleUI { | 10 class BubbleUI { |
| 9 public: | 11 public: |
| 10 virtual ~BubbleUI() {} | 12 virtual ~BubbleUI() {} |
| 11 | 13 |
| 12 // Should display the bubble UI. | 14 // Should display the bubble UI. BubbleReference is passed in so that the |
| 13 virtual void Show() = 0; | 15 // bubble UI can notify the BubbleManager if it needs to close. |
| 16 virtual void Show(BubbleReference bubbleReference) = 0; | |
|
please use gerrit instead
2015/09/08 20:43:05
bubble_reference
hcarmona
2015/09/08 21:49:47
Done.
| |
| 14 | 17 |
| 15 // Should close the bubble UI. | 18 // Should close the bubble UI. |
| 16 virtual void Close() = 0; | 19 virtual void Close() = 0; |
| 17 | 20 |
| 18 // Should update the bubble UI's position. | 21 // Should update the bubble UI's position. |
| 19 // Important to verify that an anchor is still available. | 22 // Important to verify that an anchor is still available. |
| 20 // ex: fullscreen might not have a location bar in views. | 23 // ex: fullscreen might not have a location bar in views. |
| 21 virtual void UpdateAnchorPosition() = 0; | 24 virtual void UpdateAnchorPosition() = 0; |
| 22 }; | 25 }; |
| 23 | 26 |
| 24 #endif // COMPONENTS_BUBBLE_BUBBLE_UI_H_ | 27 #endif // COMPONENTS_BUBBLE_BUBBLE_UI_H_ |
| OLD | NEW |
