Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: components/bubble/bubble_manager_unittest.cc

Issue 1323133002: Pass a BubbleReference to BubbleUI::Show. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bubbleReference -> bubble_reference Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bubble/bubble_manager.h ('k') | components/bubble/bubble_reference.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bubble/bubble_manager_unittest.cc
diff --git a/components/bubble/bubble_manager_unittest.cc b/components/bubble/bubble_manager_unittest.cc
index f18c678985d83dfb47f7d9d274b521f915cda992..84ed380aa31a6b33c76c4ff12d2f0da3851801a7 100644
--- a/components/bubble/bubble_manager_unittest.cc
+++ b/components/bubble/bubble_manager_unittest.cc
@@ -17,7 +17,7 @@ class MockBubbleUI : public BubbleUI {
MockBubbleUI() {}
~MockBubbleUI() override { Destroyed(); }
- MOCK_METHOD0(Show, void());
+ MOCK_METHOD1(Show, void(BubbleReference));
MOCK_METHOD0(Close, void());
MOCK_METHOD0(UpdateAnchorPosition, void());
@@ -118,7 +118,7 @@ TEST_F(BubbleManagerTest, ManagerShowsBubbleUI) {
// Manager will delete bubble_ui.
MockBubbleUI* bubble_ui = new MockBubbleUI;
EXPECT_CALL(*bubble_ui, Destroyed());
- EXPECT_CALL(*bubble_ui, Show());
+ EXPECT_CALL(*bubble_ui, Show(testing::_));
EXPECT_CALL(*bubble_ui, Close());
EXPECT_CALL(*bubble_ui, UpdateAnchorPosition()).Times(0);
@@ -137,7 +137,7 @@ TEST_F(BubbleManagerTest, ManagerUpdatesBubbleUI) {
// Manager will delete bubble_ui.
MockBubbleUI* bubble_ui = new MockBubbleUI;
EXPECT_CALL(*bubble_ui, Destroyed());
- EXPECT_CALL(*bubble_ui, Show());
+ EXPECT_CALL(*bubble_ui, Show(testing::_));
EXPECT_CALL(*bubble_ui, Close());
EXPECT_CALL(*bubble_ui, UpdateAnchorPosition());
« no previous file with comments | « components/bubble/bubble_manager.h ('k') | components/bubble/bubble_reference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698