components/bubble/bubble_controller.cc - Issue 1323133002: Pass a BubbleReference to BubbleUI::Show.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bubble/bubble_controller.cc

Issue 1323133002: Pass a BubbleReference to BubbleUI::Show. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bubbleReference -> bubble_reference Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bubble/bubble_controller.cc

diff --git a/components/bubble/bubble_controller.cc b/components/bubble/bubble_controller.cc

index 877b3f8dfcf047b69aae4a53d3d4081cc0c5a8d6..e32cd21716428aa0845c41c6a865a6c4ff0b1849 100644

--- a/components/bubble/bubble_controller.cc

+++ b/components/bubble/bubble_controller.cc

@@ -28,7 +28,7 @@ void BubbleController::Show() {

DCHECK(!bubble_ui_);

bubble_ui_ = delegate_->BuildBubbleUI();

DCHECK(bubble_ui_);

- bubble_ui_->Show();

+ bubble_ui_->Show(AsWeakPtr());

// TODO(hcarmona): log that bubble was shown.

}

« no previous file with comments | « components/bubble/BUILD.gn ('k') | components/bubble/bubble_manager.h » ('j') | no next file with comments »