Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1318793005: [part 2] Make classes and structures in modules fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, tzik, johnme+watch_chromium.org, eric.carlson_apple.com, dgrogan, jsbell+serviceworker_chromium.org, yhirano+watch_chromium.org, gyuyoung2, philipj_slow, timvolodine, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, nhiroki, jsbell+idb_chromium.org, michaeln, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, serviceworker-reviews, falken, mvanouwerkerk+watch_chromium.org, kinuko+serviceworker, cmumford, horo+watch_chromium.org, peter+watch_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[part 2] Make classes and structures in modules fast-allocated. - modified: modules/gamepad, geofencing, geolocation, indexeddb, mediasession, mediastream, navigatorcontentutils, permissions, presentation, push_messaging, quota, screen_orientation, serviceworkers, speech, storage, vibration, vr, webaudio, webdatabase, webmidi, websockets, and platform/audio. - Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -45 lines) Patch
M Source/modules/gamepad/GamepadDispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/geofencing/GeofencingError.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/modules/geolocation/GeolocationClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/testing/InternalsGeolocation.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/imagebitmap/WindowImageBitmapFactories.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBEventDispatcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyPath.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBMetadata.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/WebIDBCallbacksImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasession/HTMLMediaElementMediaSession.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasource/HTMLVideoElementMediaSource.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/modules/mediasource/HTMLVideoElementMediaSource.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/mediasource/URLMediaSource.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/mediastream/URLMediaStream.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/mediastream/UserMediaClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/mediastream/UserMediaController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/permissions/PermissionCallback.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/permissions/PermissionController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/PresentationError.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/modules/push_messaging/PushController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/push_messaging/PushError.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/push_messaging/PushPermissionStatusCallbacks.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/push_messaging/PushSubscriptionCallbacks.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/DOMWindowQuota.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/screen_orientation/LockOrientationCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/testing/InternalsServiceWorker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/speech/testing/InternalsSpeechSynthesis.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/storage/DOMWindowStorage.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/storage/DOMWindowStorageController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/storage/StorageNamespace.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/storage/StorageNamespaceController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/vibration/testing/InternalsVibration.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/vr/VRGetDevicesCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/AsyncAudioDecoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/AudioNodeInput.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioNodeOutput.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/AudioParamTimeline.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/RealtimeAnalyser.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/testing/InternalsWebAudio.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/ChangeVersionData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/modules/webdatabase/QuotaTracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/SQLError.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webdatabase/sqlite/SQLValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteFileSystem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/InspectorWebSocketEvents.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/websockets/WebSocketFrame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/audio/AudioDSPKernel.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/audio/AudioProcessor.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-09-02 11:02:51 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-02 11:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318793005/1
5 years, 3 months ago (2015-09-03 04:48:59 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 05:43:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201701

Powered by Google App Engine
This is Rietveld 408576698