Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315513008: Cleanup GrDrawTarget now that all paths lead to GrBatch (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@patharray
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cleanup GrDrawTarget now that all paths lead to GrBatch Committed: https://skia.googlesource.com/skia/+/512be5340c2a29550053d35bc058d3aecd5c1fc7

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : revert changes to circular clip gm #

Patch Set 4 : remove change to SampleApp.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -523 lines) Patch
M gyp/gpu.gypi View 1 5 chunks +0 lines, -12 lines 0 comments Download
D src/gpu/GrBufferedDrawTarget.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D src/gpu/GrBufferedDrawTarget.cpp View 1 1 chunk +0 lines, -37 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 3 chunks +5 lines, -13 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 9 chunks +85 lines, -9 lines 0 comments Download
D src/gpu/GrImmediateDrawTarget.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
D src/gpu/GrImmediateDrawTarget.cpp View 1 1 chunk +0 lines, -47 lines 0 comments Download
D src/gpu/GrInOrderCommandBuilder.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
D src/gpu/GrInOrderCommandBuilder.cpp View 1 1 chunk +0 lines, -29 lines 0 comments Download
D src/gpu/GrReorderCommandBuilder.h View 1 1 chunk +0 lines, -25 lines 0 comments Download
D src/gpu/GrReorderCommandBuilder.cpp View 1 1 chunk +0 lines, -82 lines 0 comments Download
D src/gpu/GrTargetCommands.h View 1 1 chunk +0 lines, -99 lines 0 comments Download
D src/gpu/GrTargetCommands.cpp View 1 1 chunk +0 lines, -48 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrTracing.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1333943002 Patch 1
Issue 1333943002 Patch 20001

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315513008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315513008/60001
5 years, 3 months ago (2015-09-10 16:08:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-10 16:13:19 UTC) #5
bsalomon
5 years, 3 months ago (2015-09-10 16:13:48 UTC) #6
joshualitt
On 2015/09/10 16:13:48, bsalomon wrote: lgtm
5 years, 3 months ago (2015-09-10 17:07:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315513008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315513008/60001
5 years, 3 months ago (2015-09-10 17:39:17 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 17:42:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/512be5340c2a29550053d35bc058d3aecd5c1fc7

Powered by Google App Engine
This is Rietveld 408576698