Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315283002: [DevTools] Reverse dependencies between InspectorOverlay and agents. (Closed)

Created:
5 years, 3 months ago by dgozman
Modified:
5 years, 3 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Reverse dependencies between InspectorOverlay and agents. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201436

Patch Set 1 #

Patch Set 2 : Fixed compile #

Patch Set 3 : more compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -246 lines) Patch
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 2 5 chunks +14 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 2 9 chunks +19 lines, -12 lines 0 comments Download
D Source/core/inspector/InspectorOverlay.h View 1 chunk +0 lines, -73 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 5 chunks +11 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 7 chunks +18 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 4 chunks +10 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 5 chunks +8 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 3 chunks +3 lines, -10 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 4 chunks +3 lines, -19 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorOverlayImpl.h View 5 chunks +34 lines, -19 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 9 chunks +36 lines, -60 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 7 chunks +8 lines, -7 lines 0 comments Download

Dependent Patchsets:

Issue 1322593003 Patch 20001

Messages

Total messages: 22 (11 generated)
dgozman
Take a look please.
5 years, 3 months ago (2015-08-27 02:30:51 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-08-27 18:50:32 UTC) #4
sergeyv
lgtm
5 years, 3 months ago (2015-08-27 18:52:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315283002/1
5 years, 3 months ago (2015-08-27 22:13:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/33889)
5 years, 3 months ago (2015-08-27 22:49:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315283002/20001
5 years, 3 months ago (2015-08-28 00:58:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99840)
5 years, 3 months ago (2015-08-28 01:20:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315283002/40001
5 years, 3 months ago (2015-08-28 18:17:34 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/38006)
5 years, 3 months ago (2015-08-28 18:20:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315283002/40001
5 years, 3 months ago (2015-08-28 21:37:05 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 22:53:58 UTC) #22
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201436

Powered by Google App Engine
This is Rietveld 408576698