Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: Source/core/inspector/InspectorPageAgent.h

Issue 1315283002: [DevTools] Reverse dependencies between InspectorOverlay and agents. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more compile Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorOverlay.h ('k') | Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorPageAgent.h
diff --git a/Source/core/inspector/InspectorPageAgent.h b/Source/core/inspector/InspectorPageAgent.h
index 50c91a1e40d208f9a9b862bfcd9f1ff375f19311..e755ad418b2123ed4f2a66700874b5938e9d29a1 100644
--- a/Source/core/inspector/InspectorPageAgent.h
+++ b/Source/core/inspector/InspectorPageAgent.h
@@ -47,7 +47,6 @@ class DocumentLoader;
class FrameHost;
class InspectorCSSAgent;
class InspectorDebuggerAgent;
-class InspectorOverlay;
class InspectorResourceContentLoader;
class KURL;
class LocalFrame;
@@ -59,6 +58,14 @@ typedef String ErrorString;
class CORE_EXPORT InspectorPageAgent final : public InspectorBaseAgent<InspectorPageAgent, InspectorFrontend::Page>, public InspectorBackendDispatcher::PageCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorPageAgent);
public:
+ class Client {
+ public:
+ virtual ~Client() { }
+ virtual void pageLayoutInvalidated(bool resized) { }
+ virtual void setShowViewportSizeOnResize(bool show, bool showGrid) { }
+ virtual void setPausedInDebuggerMessage(const String*) { }
+ };
+
enum ResourceType {
DocumentResource,
StylesheetResource,
@@ -74,7 +81,7 @@ public:
OtherResource
};
- static PassOwnPtrWillBeRawPtr<InspectorPageAgent> create(LocalFrame* inspectedFrame, InspectorOverlay*, InspectorResourceContentLoader*);
+ static PassOwnPtrWillBeRawPtr<InspectorPageAgent> create(LocalFrame* inspectedFrame, Client*, InspectorResourceContentLoader*);
void setDebuggerAgent(InspectorDebuggerAgent*);
static Vector<Document*> importsForFrame(LocalFrame*);
@@ -134,7 +141,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- InspectorPageAgent(LocalFrame* inspectedFrame, InspectorOverlay*, InspectorResourceContentLoader*);
+ InspectorPageAgent(LocalFrame* inspectedFrame, Client*, InspectorResourceContentLoader*);
void finishReload();
void getResourceContentAfterResourcesContentLoaded(const String& frameId, const String& url, PassRefPtrWillBeRawPtr<GetResourceContentCallback>);
@@ -145,7 +152,7 @@ private:
PassRefPtr<TypeBuilder::Page::FrameResourceTree> buildObjectForFrameTree(LocalFrame*);
RawPtrWillBeMember<LocalFrame> m_inspectedFrame;
RawPtrWillBeMember<InspectorDebuggerAgent> m_debuggerAgent;
- RawPtrWillBeMember<InspectorOverlay> m_overlay;
+ Client* m_client;
long m_lastScriptIdentifier;
String m_pendingScriptToEvaluateOnLoadOnce;
String m_scriptToEvaluateOnLoadOnce;
« no previous file with comments | « Source/core/inspector/InspectorOverlay.h ('k') | Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698