Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: Source/core/inspector/PageDebuggerAgent.cpp

Issue 1315283002: [DevTools] Reverse dependencies between InspectorOverlay and agents. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more compile Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/PageDebuggerAgent.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageDebuggerAgent.cpp
diff --git a/Source/core/inspector/PageDebuggerAgent.cpp b/Source/core/inspector/PageDebuggerAgent.cpp
index 8f22a25f7ef14cdf4193c61649624a3e9ac0d0ee..82aa5708b6d08fecec33281f59b5f812bdf3a989 100644
--- a/Source/core/inspector/PageDebuggerAgent.cpp
+++ b/Source/core/inspector/PageDebuggerAgent.cpp
@@ -38,7 +38,6 @@
#include "core/frame/LocalFrame.h"
#include "core/inspector/InjectedScript.h"
#include "core/inspector/InspectorInstrumentation.h"
-#include "core/inspector/InspectorOverlay.h"
#include "core/inspector/InspectorPageAgent.h"
#include "core/inspector/InspectorTraceEvents.h"
#include "core/inspector/InstrumentingAgents.h"
@@ -52,17 +51,15 @@ using blink::TypeBuilder::Runtime::RemoteObject;
namespace blink {
-PassOwnPtrWillBeRawPtr<PageDebuggerAgent> PageDebuggerAgent::create(MainThreadDebugger* mainThreadDebugger, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
+PassOwnPtrWillBeRawPtr<PageDebuggerAgent> PageDebuggerAgent::create(MainThreadDebugger* mainThreadDebugger, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager)
{
- return adoptPtrWillBeNoop(new PageDebuggerAgent(mainThreadDebugger, pageAgent, injectedScriptManager, overlay));
+ return adoptPtrWillBeNoop(new PageDebuggerAgent(mainThreadDebugger, pageAgent, injectedScriptManager));
}
-PageDebuggerAgent::PageDebuggerAgent(MainThreadDebugger* mainThreadDebugger, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, InspectorOverlay* overlay)
+PageDebuggerAgent::PageDebuggerAgent(MainThreadDebugger* mainThreadDebugger, InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager)
: InspectorDebuggerAgent(injectedScriptManager, mainThreadDebugger->debugger(), mainThreadDebugger->contextGroupId(pageAgent->inspectedFrame()))
, m_pageAgent(pageAgent)
- , m_overlay(overlay)
{
- m_overlay->setListener(this);
}
PageDebuggerAgent::~PageDebuggerAgent()
@@ -72,7 +69,6 @@ PageDebuggerAgent::~PageDebuggerAgent()
DEFINE_TRACE(PageDebuggerAgent)
{
visitor->trace(m_pageAgent);
- visitor->trace(m_overlay);
InspectorDebuggerAgent::trace(visitor);
}
@@ -121,18 +117,6 @@ void PageDebuggerAgent::unmuteConsole()
FrameConsole::unmute();
}
-void PageDebuggerAgent::overlayResumed()
-{
- ErrorString error;
- resume(&error);
-}
-
-void PageDebuggerAgent::overlaySteppedOver()
-{
- ErrorString error;
- stepOver(&error);
-}
-
InjectedScript PageDebuggerAgent::defaultInjectedScript()
{
ScriptState* scriptState = ScriptState::forMainWorld(m_pageAgent->inspectedFrame());
« no previous file with comments | « Source/core/inspector/PageDebuggerAgent.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698