Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1322593003: [DevTools] Remove InspectorOverlayHost::LayoutEditorListener. (Closed)

Created:
5 years, 3 months ago by dgozman
Modified:
5 years, 3 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Remove InspectorOverlayHost::LayoutEditorListener. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201444

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 1

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -37 lines) Patch
M Source/core/inspector/InspectorOverlayHost.h View 1 chunk +4 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.cpp View 2 chunks +12 lines, -14 lines 0 comments Download
M Source/core/inspector/LayoutEditor.h View 4 chunks +4 lines, -7 lines 0 comments Download
M Source/web/InspectorOverlayImpl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dgozman
Take a look please.
5 years, 3 months ago (2015-08-28 01:20:26 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1322593003/diff/20001/Source/core/inspector/InspectorOverlayHost.cpp File Source/core/inspector/InspectorOverlayHost.cpp (right): https://codereview.chromium.org/1322593003/diff/20001/Source/core/inspector/InspectorOverlayHost.cpp#newcode56 Source/core/inspector/InspectorOverlayHost.cpp:56: void InspectorOverlayHost::startPropertyChange(const String& anchorName) Should we place more ...
5 years, 3 months ago (2015-08-28 16:57:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322593003/20001
5 years, 3 months ago (2015-08-28 22:57:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/63084) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-08-28 22:59:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322593003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322593003/40001
5 years, 3 months ago (2015-08-29 00:06:46 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 01:57:07 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201444

Powered by Google App Engine
This is Rietveld 408576698