Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: Source/core/inspector/InspectorProfilerAgent.h

Issue 1315283002: [DevTools] Reverse dependencies between InspectorOverlay and agents. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more compile Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorPageAgent.cpp ('k') | Source/core/inspector/InspectorProfilerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorProfilerAgent.h
diff --git a/Source/core/inspector/InspectorProfilerAgent.h b/Source/core/inspector/InspectorProfilerAgent.h
index 1976e6e6c9dce80f06786e3cff1961efdea20b22..61640db78d5563d0e4af050a820a036d0e6dc4e1 100644
--- a/Source/core/inspector/InspectorProfilerAgent.h
+++ b/Source/core/inspector/InspectorProfilerAgent.h
@@ -48,7 +48,6 @@ namespace blink {
class ExecutionContext;
class InjectedScriptManager;
class InspectorFrontend;
-class InspectorOverlay;
typedef String ErrorString;
@@ -56,7 +55,14 @@ class CORE_EXPORT InspectorProfilerAgent final : public InspectorBaseAgent<Inspe
WTF_MAKE_NONCOPYABLE(InspectorProfilerAgent);
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(InspectorProfilerAgent);
public:
- static PassOwnPtrWillBeRawPtr<InspectorProfilerAgent> create(v8::Isolate*, InjectedScriptManager*, InspectorOverlay*);
+ class Client {
+ public:
+ virtual ~Client() { }
+ virtual void profilingStarted() { }
+ virtual void profilingStopped() { }
+ };
+
+ static PassOwnPtrWillBeRawPtr<InspectorProfilerAgent> create(v8::Isolate*, InjectedScriptManager*, Client*);
~InspectorProfilerAgent() override;
DECLARE_VIRTUAL_TRACE();
@@ -77,7 +83,7 @@ public:
void didLeaveNestedRunLoop();
private:
- InspectorProfilerAgent(v8::Isolate*, InjectedScriptManager*, InspectorOverlay*);
+ InspectorProfilerAgent(v8::Isolate*, InjectedScriptManager*, Client*);
bool enabled();
void doEnable();
void stop(ErrorString*, RefPtr<TypeBuilder::Profiler::CPUProfile>*);
@@ -96,7 +102,7 @@ private:
class ProfileDescriptor;
Vector<ProfileDescriptor> m_startedProfiles;
String m_frontendInitiatedProfileId;
- RawPtrWillBeMember<InspectorOverlay> m_overlay;
+ Client* m_client;
};
} // namespace blink
« no previous file with comments | « Source/core/inspector/InspectorPageAgent.cpp ('k') | Source/core/inspector/InspectorProfilerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698