cc: Remove implicit conversions from Rect to RectF in src/cc/.

cc: Remove implicit conversions from Rect to RectF in src/cc/.

This changes them to be explicit. I'd like to do this everywhere and
then make such implicit conversion not possible in the gfx classes.

R=enne, vmpstr
BUG=342848
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5e6ff6de73b07d289f236e5b2b4aa7b7e67bf2bb
Cr-Commit-Position: refs/heads/master@{#347557}

[vmpstr, 2015-08-29 00:02:46]

https://codereview.chromium.org/1314943008/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/1314943008/diff/1/cc/test/layer_test_common.c...
cc/test/layer_test_common.cc:91: ASSERT_EQ(target_rectf,
gfx::RectF(target_rect));
Why assert?

https://codereview.chromium.org/1314943008/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/1314943008/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:541:
texture_rect.Intersect(gfx::RectF(gfx::Rect(tiling_->tiling_size())));
gfx::SizeF instead of gfx::Rect maybe?

[danakj, 2015-08-29 00:13:37]

https://codereview.chromium.org/1314943008/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/1314943008/diff/1/cc/test/layer_test_common.c...
cc/test/layer_test_common.cc:91: ASSERT_EQ(target_rectf,
gfx::RectF(target_rect));
On 2015/08/29 00:02:46, vmpstr wrote:
> Why assert?

Cuz then we don't need to ToString(). And it was a DCHECK before so this is the
same behaviour.

https://codereview.chromium.org/1314943008/diff/1/cc/tiles/picture_layer_tili...
File cc/tiles/picture_layer_tiling.cc (right):

https://codereview.chromium.org/1314943008/diff/1/cc/tiles/picture_layer_tili...
cc/tiles/picture_layer_tiling.cc:541:
texture_rect.Intersect(gfx::RectF(gfx::Rect(tiling_->tiling_size())));
On 2015/08/29 00:02:46, vmpstr wrote:
> gfx::SizeF instead of gfx::Rect maybe?

Done.

[vmpstr, 2015-08-31 20:08:38]

lgtm. Thanks for doing this.

https://codereview.chromium.org/1314943008/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/1314943008/diff/1/cc/test/layer_test_common.c...
cc/test/layer_test_common.cc:91: ASSERT_EQ(target_rectf,
gfx::RectF(target_rect));
On 2015/08/29 00:13:37, danakj wrote:
> On 2015/08/29 00:02:46, vmpstr wrote:
> > Why assert?
> 
> Cuz then we don't need to ToString(). And it was a DCHECK before so this is
the
> same behaviour.

Ohh I thought this was EXPECT -> ASSERT change, not DCHECK -> ASSERT, cool.

[danakj, 2015-08-31 22:15:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-08-31 22:16:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314943008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314943008/20001

[commit-bot: I haz the power, 2015-08-31 22:21:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 22:21:53]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[danakj, 2015-08-31 23:36:21]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-08-31 23:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1314943008/#ps40001
(title: "rectfconvert-cc: .")

[commit-bot: I haz the power, 2015-08-31 23:37:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314943008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314943008/40001

[commit-bot: I haz the power, 2015-08-31 23:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 23:59:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2015-09-04 21:58:45]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-09-04 21:58:45]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1314943008/#ps60001
(title: "rectfconvert-cc: .")

[commit-bot: I haz the power, 2015-09-04 21:59:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314943008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314943008/60001

[commit-bot: I haz the power, 2015-09-04 22:01:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 22:01:47]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2015-09-04 22:50:47]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-09-04 22:50:47]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1314943008/#ps80001
(title: "rectfconvert-cc: rebase")

[commit-bot: I haz the power, 2015-09-04 22:51:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314943008/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314943008/80001

[commit-bot: I haz the power, 2015-09-04 23:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 23:03:10]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2015-09-05 00:30:27]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-09-05 00:30:27]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1314943008/#ps120001
(title: "rectfconvert-cc: rebase-and-sandwich-strategy")

[commit-bot: I haz the power, 2015-09-05 00:30:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314943008/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314943008/120001

[commit-bot: I haz the power, 2015-09-05 04:43:52]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-09-05 04:45:04]

Patchset 7 (id:??) landed as
https://crrev.com/5e6ff6de73b07d289f236e5b2b4aa7b7e67bf2bb
Cr-Commit-Position: refs/heads/master@{#347557}