cc: Remove implicit conversions from Rect to RectF in src/cc/.

cc/test/layer_test_common.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/layer_test_common.h"
 
 #include "cc/base/math_util.h"
 #include "cc/base/region.h"
 #include "cc/layers/append_quads_data.h"
 #include "cc/quads/draw_quad.h"
@@ skipping 66 matching lines @@
   // Quads that are fully occluded on one axis only should be shrunken.
   for (const auto& quad : quads) {
     gfx::Rect target_rect = MathUtil::MapEnclosingClippedRect(
         quad->shared_quad_state->quad_to_target_transform, quad->rect);
     if (!quad->shared_quad_state->quad_to_target_transform
              .IsIdentityOrIntegerTranslation()) {
       DCHECK(quad->shared_quad_state->quad_to_target_transform
                  .IsPositiveScaleOrTranslation())
           << quad->shared_quad_state->quad_to_target_transform.ToString();
       gfx::RectF target_rectf = MathUtil::MapClippedRect(
-          quad->shared_quad_state->quad_to_target_transform, quad->rect);
+          quad->shared_quad_state->quad_to_target_transform,
+          gfx::RectF(quad->rect));
       // Scale transforms allowed, as long as the final transformed rect
       // ends up on integer boundaries for ease of testing.
-      DCHECK_EQ(target_rectf.ToString(), gfx::RectF(target_rect).ToString());
+      ASSERT_EQ(target_rectf, gfx::RectF(target_rect));

[vmpstr, 2015/08/29 00:02:46]

Why assert?

[danakj, 2015/08/29 00:13:37]

Cuz then we don't need to ToString(). And it was a DCHECK before so this is the
same behaviour.

[vmpstr, 2015/08/31 20:08:38]

Ohh I thought this was EXPECT -> ASSERT change, not DCHECK -> ASSERT, cool.

     }
     gfx::Rect target_visible_rect = MathUtil::MapEnclosingClippedRect(
         quad->shared_quad_state->quad_to_target_transform, quad->visible_rect);
 
     bool fully_occluded_horizontal = target_rect.x() >= occluded.x() &&
                                      target_rect.right() <= occluded.right();
     bool fully_occluded_vertical = target_rect.y() >= occluded.y() &&
                                    target_rect.bottom() <= occluded.bottom();
     bool should_be_occluded =
         target_rect.Intersects(occluded) &&
@@ skipping 79 matching lines @@
   render_pass_->shared_quad_state_list.clear();
 
   surface_impl->AppendQuads(
       render_pass_.get(), gfx::Transform(),
       Occlusion(gfx::Transform(), SimpleEnclosedRegion(occluded),
                 SimpleEnclosedRegion()),
       SK_ColorBLACK, 1.f, nullptr, &data, RenderPassId(1, 1));
 }
 
 }  // namespace cc