Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: public/platform/modules/background_sync/WebSyncProvider.h

Issue 1314453003: [Background Sync] Allow sync manager access from uncontrolled clients (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@uncontrolled-windows
Patch Set: Rebase against dependency patchset Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/background_sync/WebSyncProvider.h
diff --git a/public/platform/modules/background_sync/WebSyncProvider.h b/public/platform/modules/background_sync/WebSyncProvider.h
index f118589cf972ac0d03d1f4467cc7e21df602bc29..175b0b1b4b82a5490845ca0bd976830db26fef83 100644
--- a/public/platform/modules/background_sync/WebSyncProvider.h
+++ b/public/platform/modules/background_sync/WebSyncProvider.h
@@ -29,14 +29,7 @@ public:
// Takes ownership of the WebSyncRegistrationCallbacks.
// Does not take ownership of the WebServiceWorkerRegistration.
- // TODO(iclelland): Remove the body of this method once it is implemented in all subclasses.
- virtual void registerBackgroundSync(const WebSyncRegistration* options, WebServiceWorkerRegistration* serviceWorkerRegistration, bool requestedFromServiceWorker, WebSyncRegistrationCallbacks* callbacks)
- {
- registerBackgroundSync(options, serviceWorkerRegistration, callbacks);
- }
-
- // TODO(iclelland): Remove this deprecated method once the browser implements the 4-argument version.
- virtual void registerBackgroundSync(const WebSyncRegistration*, WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) { }
+ virtual void registerBackgroundSync(const WebSyncRegistration*, WebServiceWorkerRegistration*, bool, WebSyncRegistrationCallbacks*) = 0;
// Takes ownership of the WebSyncUnregistrationCallbacks.
// Does not take ownership of the WebServiceWorkerRegistration.

Powered by Google App Engine
This is Rietveld 408576698