Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..." (Closed)

Created:
5 years, 3 months ago by haraken

Modified:
5 years, 3 months ago

Reviewers:
vivekg_samsung

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 201193 "[bindings] Compact ConstantConfiguration by using..." The PerfBot is not happy. http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=8587 PERF_REGRESS: chrome-bss/bss (1.93%), chrome-bss/bss (1.93%) https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=345536 > [bindings] Compact ConstantConfiguration by using |union| > > This patch uses |union| to store the constant values to reduce space required. > > This patch saves about ~4 Kbytes of in |.data.rel.ro.local| with component build on linux platform. > Also the size of V8DOMConfiguration::ConstantConfiguration is down to 24 bytes from > 40 bytes on 64bit linux build. > > BUG=469961 > > Review URL: https://codereview.chromium.org/1310443005 TBR=vivek.vg@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201209

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -60 lines)			Patch
M	trunk/Source/bindings/core/v8/V8DOMConfiguration.h	View	1 chunk	+3 lines, -21 lines	0 comments	Download
M	trunk/Source/bindings/templates/constants.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	trunk/Source/bindings/tests/results/core/V8TestException.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/bindings/tests/results/core/V8TestInterface.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	trunk/Source/bindings/tests/results/core/V8TestInterface2.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/bindings/tests/results/core/V8TestObject.cpp	View	1 chunk	+25 lines, -25 lines	0 comments	Download
M	trunk/Source/bindings/tests/results/modules/V8TestInterface5.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r201209.