Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: trunk/Source/bindings/core/v8/V8DOMConfiguration.h

Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/Source/bindings/templates/constants.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/bindings/core/v8/V8DOMConfiguration.h
===================================================================
--- trunk/Source/bindings/core/v8/V8DOMConfiguration.h (revision 201208)
+++ trunk/Source/bindings/core/v8/V8DOMConfiguration.h (working copy)
@@ -125,28 +125,10 @@
struct ConstantConfiguration {
ConstantConfiguration& operator=(const ConstantConfiguration&) = delete;
DISALLOW_ALLOCATION();
- ConstantConfiguration(const char* const name, unsigned value, ConstantType type)
- : name(name)
- , ivalue(value)
- , type(type) {}
- ConstantConfiguration(const char* const name, int value, ConstantType type)
- : name(name)
- , ivalue(value)
- , type(type) {}
- ConstantConfiguration(const char* const name, double value, ConstantType type)
- : name(name)
- , dvalue(value)
- , type(type) {}
- ConstantConfiguration(const char* const name, const char* const value, ConstantType type)
- : name(name)
- , svalue(value)
- , type(type) {}
const char* const name;
- union {
- int ivalue;
- double dvalue;
- const char* const svalue;
- };
+ int ivalue;
+ double dvalue;
+ const char* const svalue;
ConstantType type;
};
« no previous file with comments | « no previous file | trunk/Source/bindings/templates/constants.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698