Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1310443005: [bindings] Compact ConstantConfiguration by using |union| (Closed)

Created:
5 years, 4 months ago by vivekg_samsung
Modified:
5 years, 4 months ago
Reviewers:
haraken, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Compact ConstantConfiguration by using |union| This patch uses |union| to store the constant values to reduce space required. This patch saves about ~4 Kbytes of in |.data.rel.ro.local| with component build on linux platform. Also the size of V8DOMConfiguration::ConstantConfiguration is down to 24 bytes from 40 bytes on 64bit linux build. BUG=469961 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -42 lines) Patch
M Source/bindings/core/v8/V8DOMConfiguration.h View 1 chunk +21 lines, -3 lines 0 comments Download
M Source/bindings/templates/constants.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +25 lines, -25 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310443005/1
5 years, 4 months ago (2015-08-25 14:06:32 UTC) #4
vivekg
PTAL and let me know your thoughts on this. Thanks!
5 years, 4 months ago (2015-08-25 17:47:50 UTC) #7
haraken
LGTM
5 years, 4 months ago (2015-08-25 23:32:43 UTC) #8
haraken
We haven't yet studied how much binary size is consumed by these static data structures ...
5 years, 4 months ago (2015-08-25 23:34:20 UTC) #9
vivekg
On 2015/08/25 23:34:20, haraken wrote: > We haven't yet studied how much binary size is ...
5 years, 4 months ago (2015-08-26 00:24:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310443005/1
5 years, 4 months ago (2015-08-26 00:24:29 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 03:22:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201193

Powered by Google App Engine
This is Rietveld 408576698