trunk/Source/bindings/tests/results/core/V8TestInterface2.cpp - Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..." (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | trunk/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/Source/bindings/tests/results/core/V8TestInterface2.cpp

===================================================================

--- trunk/Source/bindings/tests/results/core/V8TestInterface2.cpp (revision 201208)

+++ trunk/Source/bindings/tests/results/core/V8TestInterface2.cpp (working copy)

@@ -655,7 +655,7 @@

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

if (RuntimeEnabledFeatures::featureNameEnabled()) {

- static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"CONST_VALUE_1", 1, V8DOMConfiguration::ConstantTypeUnsignedShort};

+ static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"CONST_VALUE_1", 1, 0, 0, V8DOMConfiguration::ConstantTypeUnsignedShort};

V8DOMConfiguration::installConstant(isolate, functionTemplate, prototypeTemplate, constantConfiguration);

}

static_assert(1 == TestInterface2::CONST_VALUE_1, "the value of TestInterface2_CONST_VALUE_1 does not match with implementation");