trunk/Source/bindings/templates/constants.cpp - Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/bindings/templates/constants.cpp

Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..." (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/Source/bindings/templates/constants.cpp

===================================================================

--- trunk/Source/bindings/templates/constants.cpp (revision 201208)

+++ trunk/Source/bindings/templates/constants.cpp (working copy)

@@ -60,12 +60,12 @@

{######################################}

{%- macro constant_configuration(constant) %}

{% if constant.idl_type in ('Double', 'Float') %}

- {% set value = '%sf' % constant.value %}

+ {% set value = '0, %s, 0' % constant.value %}

{% elif constant.idl_type == 'String' %}

- {% set value = '"%s"' % constant.value %}

+ {% set value = '0, 0, "%s"' % constant.value %}

{% else %}

{# 'Short', 'Long' etc. #}

- {% set value = '%s' % constant.value %}

+ {% set value = '%s, 0, 0' % constant.value %}

{% endif %}

{"{{constant.name}}", {{value}}, V8DOMConfiguration::ConstantType{{constant.idl_type}}}

{%- endmacro %}