Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: trunk/Source/bindings/templates/constants.cpp

Issue 1314133002: Revert 201193 "[bindings] Compact ConstantConfiguration by using..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/Source/bindings/templates/constants.cpp
===================================================================
--- trunk/Source/bindings/templates/constants.cpp (revision 201208)
+++ trunk/Source/bindings/templates/constants.cpp (working copy)
@@ -60,12 +60,12 @@
{######################################}
{%- macro constant_configuration(constant) %}
{% if constant.idl_type in ('Double', 'Float') %}
- {% set value = '%sf' % constant.value %}
+ {% set value = '0, %s, 0' % constant.value %}
{% elif constant.idl_type == 'String' %}
- {% set value = '"%s"' % constant.value %}
+ {% set value = '0, 0, "%s"' % constant.value %}
{% else %}
{# 'Short', 'Long' etc. #}
- {% set value = '%s' % constant.value %}
+ {% set value = '%s, 0, 0' % constant.value %}
{% endif %}
{"{{constant.name}}", {{value}}, V8DOMConfiguration::ConstantType{{constant.idl_type}}}
{%- endmacro %}
« no previous file with comments | « trunk/Source/bindings/core/v8/V8DOMConfiguration.h ('k') | trunk/Source/bindings/tests/results/core/V8TestException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698