Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed)

Created:
5 years, 3 months ago by eakuefner
Modified:
5 years, 3 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Introduce SummarizableValue. This is a refresh of crrev.com/809393002, wherein improvement_direction was added to Value. This CL pulls out only the Telemetry-side changes in an attempt to make this CL a bit smaller; the next change will be to update Telemetry clients to use this new field. BUG=459450 Committed: https://crrev.com/5ad6f2b91267a69d173713e1607774cac8bbf58a Cr-Commit-Position: refs/heads/master@{#346410}

Patch Set 1 #

Patch Set 2 : rebase (everything is broken) #

Patch Set 3 : Telemetry unittests pass #

Patch Set 4 : Formatting fixes + remove hazardous assert in summary #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+602 lines, -247 lines) Patch
M tools/telemetry/telemetry/internal/results/chart_json_output_formatter_unittest.py View 1 2 9 chunks +26 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py View 1 4 chunks +25 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py View 1 4 chunks +13 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/json_output_formatter_unittest.py View 1 5 chunks +11 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/page_test_results_unittest.py View 1 2 13 chunks +100 lines, -35 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/story_run_unittest.py View 1 2 4 chunks +10 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 1 2 3 4 3 chunks +9 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 5 chunks +12 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 1 2 5 chunks +6 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/value/improvement_direction.py View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 1 7 chunks +21 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 2 11 chunks +40 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 1 2 6 chunks +37 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 1 5 chunks +10 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 8 chunks +36 lines, -16 lines 0 comments Download
A tools/telemetry/telemetry/value/summarizable.py View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/summary_unittest.py View 1 2 3 19 chunks +93 lines, -46 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/blob_timeline.py View 1 2 3 4 3 chunks +25 lines, -20 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/memory_timeline.py View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py View 1 2 chunks +5 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/single_event.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 1 2 9 chunks +29 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 2 3 4 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
eakuefner
PTAL. This is a pretty direct refresh of Annie's CL, which at the time was ...
5 years, 3 months ago (2015-08-27 18:33:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313243003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313243003/60001
5 years, 3 months ago (2015-08-27 18:37:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/90514) ios_dbg_simulator_ninja on ...
5 years, 3 months ago (2015-08-27 18:39:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313243003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313243003/80001
5 years, 3 months ago (2015-08-27 20:44:42 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 22:04:26 UTC) #10
sullivan
lgtm
5 years, 3 months ago (2015-08-31 13:11:50 UTC) #11
nednguyen
lgtm As discussed offline, we should gravitate toward moving the public APIs in package into ...
5 years, 3 months ago (2015-08-31 16:11:40 UTC) #12
eakuefner
On 2015/08/31 at 16:11:40, nednguyen wrote: > lgtm > As discussed offline, we should gravitate ...
5 years, 3 months ago (2015-08-31 16:30:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313243003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313243003/80001
5 years, 3 months ago (2015-08-31 16:31:52 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-08-31 17:38:15 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 17:38:50 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5ad6f2b91267a69d173713e1607774cac8bbf58a
Cr-Commit-Position: refs/heads/master@{#346410}

Powered by Google App Engine
This is Rietveld 408576698