Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: tools/telemetry/telemetry/internal/story_runner_unittest.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/story_runner_unittest.py
diff --git a/tools/telemetry/telemetry/internal/story_runner_unittest.py b/tools/telemetry/telemetry/internal/story_runner_unittest.py
index e2a5480ba208f4df19408cf9af8737ef0ee4f8de..7ea3e1508e9a7ba7a89dcf07ae313247c2121f99 100644
--- a/tools/telemetry/telemetry/internal/story_runner_unittest.py
+++ b/tools/telemetry/telemetry/internal/story_runner_unittest.py
@@ -21,6 +21,7 @@ from telemetry import story as story_module
from telemetry.testing import options_for_unittests
from telemetry.testing import system_stub
import mock
+from telemetry.value import improvement_direction
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
from telemetry.value import summary as summary_module
@@ -476,7 +477,8 @@ class StoryRunnerTest(unittest.TestCase):
def RunPage(self, page, _, results):
self.i += 1
results.AddValue(scalar.ScalarValue(
- page, 'metric', 'unit', self.i))
+ page, 'metric', 'unit', self.i,
+ improvement_direction=improvement_direction.UP))
def ValidateAndMeasurePage(self, page, tab, results):
pass
@@ -492,11 +494,14 @@ class StoryRunnerTest(unittest.TestCase):
values = summary.interleaved_computed_per_page_values_and_summaries
blank_value = list_of_scalar_values.ListOfScalarValues(
- blank_story, 'metric', 'unit', [1, 3])
+ blank_story, 'metric', 'unit', [1, 3],
+ improvement_direction=improvement_direction.UP)
green_value = list_of_scalar_values.ListOfScalarValues(
- green_story, 'metric', 'unit', [2, 4])
+ green_story, 'metric', 'unit', [2, 4],
+ improvement_direction=improvement_direction.UP)
merged_value = list_of_scalar_values.ListOfScalarValues(
- None, 'metric', 'unit', [1, 2, 3, 4])
+ None, 'metric', 'unit', [1, 2, 3, 4],
+ improvement_direction=improvement_direction.UP)
self.assertEquals(4, GetNumberOfSuccessfulPageRuns(results))
self.assertEquals(0, len(results.failures))
« no previous file with comments | « tools/telemetry/telemetry/internal/results/story_run_unittest.py ('k') | tools/telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698