Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: tools/telemetry/telemetry/value/summarizable.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/summarizable.py
diff --git a/tools/telemetry/telemetry/value/summarizable.py b/tools/telemetry/telemetry/value/summarizable.py
new file mode 100644
index 0000000000000000000000000000000000000000..3b44c894a2ba300a7612c4290495d41af6f6167f
--- /dev/null
+++ b/tools/telemetry/telemetry/value/summarizable.py
@@ -0,0 +1,68 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from telemetry import value as value_module
+
+
+class SummarizableValue(value_module.Value):
+ def __init__(self, page, name, units, important, description, tir_label,
+ improvement_direction):
+ """A summarizable value result from a test."""
+ super(SummarizableValue, self).__init__(
+ page, name, units, important, description, tir_label)
+# TODO(eakuefner): uncomment this assert after Telemetry clients are fixed.
+# Note: Telemetry unittests satisfy this assert.
+# assert improvement_direction_module.IsValid(improvement_direction)
+ self._improvement_direction = improvement_direction
+
+ @property
+ def improvement_direction(self):
+ return self._improvement_direction
+
+ def AsDict(self):
+ d = super(SummarizableValue, self).AsDict()
+ d['improvement_direction'] = self.improvement_direction
+ return d
+
+ @staticmethod
+ def GetJSONTypeName():
+ return 'summarizable'
+
+ def AsDictWithoutBaseClassEntries(self):
+ d = super(SummarizableValue, self).AsDictWithoutBaseClassEntries()
+ del d['improvement_direction']
+ return d
+
+ def GetBuildbotDataType(self, output_context):
+ """Returns the buildbot's equivalent data_type.
+
+ This should be one of the values accepted by perf_tests_results_helper.py.
+ """
+ raise NotImplementedError()
+
+ def GetBuildbotValue(self):
+ """Returns the buildbot's equivalent value."""
+ raise NotImplementedError()
+
+ @classmethod
+ def MergeLikeValuesFromSamePage(cls, values):
+ raise NotImplementedError()
+
+ @classmethod
+ def MergeLikeValuesFromDifferentPages(cls, values):
+ raise NotImplementedError()
+
+ def GetRepresentativeNumber(self):
+ """Gets a single scalar value that best-represents this value.
+
+ Returns None if not possible.
+ """
+ raise NotImplementedError()
+
+ def GetRepresentativeString(self):
+ """Gets a string value that best-represents this value.
+
+ Returns None if not possible.
+ """
+ raise NotImplementedError()
« no previous file with comments | « tools/telemetry/telemetry/value/scalar_unittest.py ('k') | tools/telemetry/telemetry/value/summary_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698