| Index: tools/telemetry/telemetry/internal/results/chart_json_output_formatter_unittest.py
|
| diff --git a/tools/telemetry/telemetry/internal/results/chart_json_output_formatter_unittest.py b/tools/telemetry/telemetry/internal/results/chart_json_output_formatter_unittest.py
|
| index 27fa30257cff5491f18cbb14f9f38ab015196957..61baf615024381d10cce42e8e1044c044459a65a 100644
|
| --- a/tools/telemetry/telemetry/internal/results/chart_json_output_formatter_unittest.py
|
| +++ b/tools/telemetry/telemetry/internal/results/chart_json_output_formatter_unittest.py
|
| @@ -12,6 +12,7 @@ from telemetry import story
|
| from telemetry.internal.results import chart_json_output_formatter
|
| from telemetry.internal.results import page_test_results
|
| from telemetry import page as page_module
|
| +from telemetry.value import improvement_direction
|
| from telemetry.value import list_of_scalar_values
|
| from telemetry.value import scalar
|
|
|
| @@ -37,7 +38,8 @@ class ChartJsonTest(unittest.TestCase):
|
| self._output.truncate(0)
|
|
|
| results.WillRunPage(self._story_set[0])
|
| - v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)
|
| + v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3,
|
| + improvement_direction=improvement_direction.DOWN)
|
| results.AddValue(v0)
|
| results.DidRunPage(self._story_set[0])
|
|
|
| @@ -46,7 +48,8 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertIn('foo', d['charts'])
|
|
|
| def testAsChartDictSerializable(self):
|
| - v0 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 3)
|
| + v0 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 3,
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = [v0]
|
| summary_values = []
|
|
|
| @@ -84,8 +87,10 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertEquals('', d['benchmark_metadata']['description'])
|
|
|
| def testAsChartDictPageSpecificValuesSamePage(self):
|
| - v0 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 3)
|
| - v1 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 4)
|
| + v0 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 3,
|
| + improvement_direction=improvement_direction.DOWN)
|
| + v1 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 4,
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = [v0, v1]
|
| summary_values = []
|
|
|
| @@ -98,8 +103,10 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertTrue('http://www.foo.com/' in d['charts']['foo'])
|
|
|
| def testAsChartDictPageSpecificValuesAndComputedSummaryWithTraceName(self):
|
| - v0 = scalar.ScalarValue(self._story_set[0], 'foo.bar', 'seconds', 3)
|
| - v1 = scalar.ScalarValue(self._story_set[1], 'foo.bar', 'seconds', 4)
|
| + v0 = scalar.ScalarValue(self._story_set[0], 'foo.bar', 'seconds', 3,
|
| + improvement_direction=improvement_direction.DOWN)
|
| + v1 = scalar.ScalarValue(self._story_set[1], 'foo.bar', 'seconds', 4,
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = [v0, v1]
|
| summary_values = []
|
|
|
| @@ -114,8 +121,10 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertTrue('bar' in d['charts']['foo'])
|
|
|
| def testAsChartDictPageSpecificValuesAndComputedSummaryWithoutTraceName(self):
|
| - v0 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 3)
|
| - v1 = scalar.ScalarValue(self._story_set[1], 'foo', 'seconds', 4)
|
| + v0 = scalar.ScalarValue(self._story_set[0], 'foo', 'seconds', 3,
|
| + improvement_direction=improvement_direction.DOWN)
|
| + v1 = scalar.ScalarValue(self._story_set[1], 'foo', 'seconds', 4,
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = [v0, v1]
|
| summary_values = []
|
|
|
| @@ -130,8 +139,9 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertTrue('summary' in d['charts']['foo'])
|
|
|
| def testAsChartDictSummaryValueWithTraceName(self):
|
| - v0 = list_of_scalar_values.ListOfScalarValues(None, 'foo.bar', 'seconds',
|
| - [3, 4])
|
| + v0 = list_of_scalar_values.ListOfScalarValues(
|
| + None, 'foo.bar', 'seconds', [3, 4],
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = []
|
| summary_values = [v0]
|
|
|
| @@ -143,8 +153,9 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertTrue('bar' in d['charts']['foo'])
|
|
|
| def testAsChartDictSummaryValueWithoutTraceName(self):
|
| - v0 = list_of_scalar_values.ListOfScalarValues(None, 'foo', 'seconds',
|
| - [3, 4])
|
| + v0 = list_of_scalar_values.ListOfScalarValues(
|
| + None, 'foo', 'seconds', [3, 4],
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = []
|
| summary_values = [v0]
|
|
|
| @@ -156,8 +167,9 @@ class ChartJsonTest(unittest.TestCase):
|
| self.assertTrue('summary' in d['charts']['foo'])
|
|
|
| def testAsChartDictValueSmokeTest(self):
|
| - v0 = list_of_scalar_values.ListOfScalarValues(None, 'foo.bar', 'seconds',
|
| - [3, 4])
|
| + v0 = list_of_scalar_values.ListOfScalarValues(
|
| + None, 'foo.bar', 'seconds', [3, 4],
|
| + improvement_direction=improvement_direction.DOWN)
|
| page_specific_values = []
|
| summary_values = [v0]
|
|
|
|
|