Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py

Issue 1313243003: [Telemetry] Introduce SummarizableValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py b/tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py
index 78b8c47a07bb5c5c2cc9518aabc9ed904a251494..178dfd60ac0905a1feca5eb22756786a436d6e40 100644
--- a/tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/internal/results/html_output_formatter_unittest.py
@@ -11,6 +11,7 @@ from telemetry import story
from telemetry.internal.results import html_output_formatter
from telemetry.internal.results import page_test_results
from telemetry import page as page_module
+from telemetry.value import improvement_direction
from telemetry.value import scalar
@@ -55,12 +56,14 @@ class HtmlOutputFormatterTest(unittest.TestCase):
results = page_test_results.PageTestResults()
results.WillRunPage(test_story_set.stories[0])
results.AddValue(scalar.ScalarValue(
- test_story_set.stories[0], 'a', 'seconds', 3))
+ test_story_set.stories[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(test_story_set.stories[0])
results.WillRunPage(test_story_set.stories[1])
results.AddValue(scalar.ScalarValue(
- test_story_set.stories[1], 'a', 'seconds', 7))
+ test_story_set.stories[1], 'a', 'seconds', 7,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(test_story_set.stories[1])
formatter = DeterministicHtmlOutputFormatter(
@@ -104,12 +107,14 @@ class HtmlOutputFormatterTest(unittest.TestCase):
results = page_test_results.PageTestResults()
results.WillRunPage(test_story_set.stories[0])
results.AddValue(scalar.ScalarValue(
- test_story_set.stories[0], 'a', 'seconds', 4))
+ test_story_set.stories[0], 'a', 'seconds', 4,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(test_story_set.stories[0])
results.WillRunPage(test_story_set.stories[1])
results.AddValue(scalar.ScalarValue(
- test_story_set.stories[1], 'a', 'seconds', 8))
+ test_story_set.stories[1], 'a', 'seconds', 8,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(test_story_set.stories[1])
formatter = DeterministicHtmlOutputFormatter(
@@ -186,12 +191,14 @@ class HtmlOutputFormatterTest(unittest.TestCase):
results = page_test_results.PageTestResults()
results.WillRunPage(test_story_set.stories[0])
results.AddValue(scalar.ScalarValue(
- test_story_set.stories[0], 'a', 'seconds', 5))
+ test_story_set.stories[0], 'a', 'seconds', 5,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(test_story_set.stories[0])
results.WillRunPage(test_story_set.stories[1])
results.AddValue(scalar.ScalarValue(
- test_story_set.stories[1], 'a', 'seconds', 9))
+ test_story_set.stories[1], 'a', 'seconds', 9,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(test_story_set.stories[1])
formatter = DeterministicHtmlOutputFormatter(

Powered by Google App Engine
This is Rietveld 408576698