Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1310043003: Introduce previousPositionOf() for VisiblePosition (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, groby+blinkspell_chromium.org, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce previousPositionOf() for VisiblePosition This patch introduces |previousPositionOf()| function for |VisiblePosition| as replacement of |VisiblePosition::previous()| to simplify |VisiblePosition| class for ease of templataizing |VisiblePosition| class to introduce composed tree version of |VisiblePosition|, since an implementation of |VisiblePosition::previous()| can be implemented with public member functions of |VisiblePosition| class. This patch also moves |VisiblePosition::characterBefore()| into "VisiblePosition.cpp" to avoid forward declaration of |previousPositionOf()|. Note: http://crrev.com/1307803003 introduces |nextPositionOf()|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201382

Patch Set 1 : 2015-08-28T16:28:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -57 lines) Patch
M Source/core/editing/EditingUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/Editor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 3 chunks +12 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/editing/commands/InsertListCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/ReplaceSelectionCommand.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/commands/TypingCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/serializers/StyledMarkupSerializer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-28 08:12:23 UTC) #3
tkent
lgtm
5 years, 3 months ago (2015-08-28 08:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310043003/1
5 years, 3 months ago (2015-08-28 08:34:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 08:39:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201382

Powered by Google App Engine
This is Rietveld 408576698