Source/core/frame/LocalFrame.cpp - Issue 1310043003: Introduce previousPositionOf() for VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 1310043003: Introduce previousPositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-28T16:28:03 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index decf938ae111770ca07bd2c53beeaed53e664cc9..7f462b0c8a603e05862ea7138ba88b2e9808fd8b 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -707,7 +707,7 @@ EphemeralRange LocalFrame::rangeForPoint(const IntPoint& framePoint)

return EphemeralRange();

VisiblePosition position(positionWithAffinity);

- VisiblePosition previous = position.previous();

+ VisiblePosition previous = previousPositionOf(position);

if (previous.isNotNull()) {

const EphemeralRange previousCharacterRange = makeRange(previous, position);

IntRect rect = editor().firstRectForRange(previousCharacterRange);

« no previous file with comments | « Source/core/editing/spellcheck/SpellChecker.cpp ('k') | no next file » | no next file with comments »