Source/core/editing/commands/BreakBlockquoteCommand.cpp - Issue 1310043003: Introduce previousPositionOf() for VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/BreakBlockquoteCommand.cpp

Issue 1310043003: Introduce previousPositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-28T16:28:03 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/commands/ApplyBlockElementCommand.cpp ('k') | Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/commands/BreakBlockquoteCommand.cpp

diff --git a/Source/core/editing/commands/BreakBlockquoteCommand.cpp b/Source/core/editing/commands/BreakBlockquoteCommand.cpp

index 4369b3d81c2b96d782708d66ef8b05b3431fcdff..83e4a6c7dd73427a4788aec484ec6610f6ee5c19 100644

--- a/Source/core/editing/commands/BreakBlockquoteCommand.cpp

+++ b/Source/core/editing/commands/BreakBlockquoteCommand.cpp

@@ -50,7 +50,7 @@ bool isFirstVisiblePositionInNode(const VisiblePosition& visiblePosition, const

if (!visiblePosition.deepEquivalent().computeContainerNode()->isDescendantOf(node))

return false;

- VisiblePosition previous = visiblePosition.previous();

+ VisiblePosition previous = previousPositionOf(visiblePosition);

return previous.isNull() || !previous.deepEquivalent().anchorNode()->isDescendantOf(node);

}

« no previous file with comments | « Source/core/editing/commands/ApplyBlockElementCommand.cpp ('k') | Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »