Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 1310043003: Introduce previousPositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T16:28:03 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/editing/commands/ApplyBlockElementCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp
index f564c58bff491f975f48bcf636859cb829d72876..6aaa4a8549c40c3ba3dd602236924a0fa8f9b7bf 100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -697,7 +697,7 @@ VisiblePosition endOfWord(const VisiblePosition& c, EWordSide side)
if (isStartOfParagraph(c))
return c;
- p = c.previous();
+ p = previousPositionOf(c);
if (p.isNull())
return c;
} else if (isEndOfParagraph(c)) {
@@ -893,7 +893,7 @@ static VisiblePosition endOfLine(const VisiblePosition& c, LineEndpointComputati
// a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg </div>
// In this case, use the previous position of the computed logical end position.
if (!inSameLogicalLine(c, visPos))
- visPos = visPos.previous();
+ visPos = previousPositionOf(visPos);
if (ContainerNode* editableRoot = highestEditableRoot(c.deepEquivalent())) {
if (!editableRoot->contains(visPos.deepEquivalent().computeContainerNode()))
@@ -909,7 +909,7 @@ static VisiblePosition endOfLine(const VisiblePosition& c, LineEndpointComputati
// in the next line instead. This fix is to account for the discrepancy between lines with webkit-line-break:after-white-space style
// versus lines without that style, which would break before a space by default.
if (!inSameLine(c, visPos)) {
- visPos = c.previous();
+ visPos = previousPositionOf(c);
if (visPos.isNull())
return VisiblePosition();
visPos = endPositionForLine(visPos, UseInlineBoxOrdering);
@@ -1415,7 +1415,7 @@ VisiblePosition endOfDocument(const VisiblePosition& c)
bool isStartOfDocument(const VisiblePosition& p)
{
- return p.isNotNull() && p.previous(CanCrossEditingBoundary).isNull();
+ return p.isNotNull() && previousPositionOf(p, CanCrossEditingBoundary).isNull();
}
bool isEndOfDocument(const VisiblePosition& p)
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/editing/commands/ApplyBlockElementCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698