Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp - Issue 1310043003: Introduce previousPositionOf() for VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 1310043003: Introduce previousPositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-28T16:28:03 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/commands/InsertListCommand.cpp ('k') | Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

diff --git a/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

index 7ca8bc22686d090490671f9b2f6ca7764459a194..9c86842227e0fabba6664fbcb0c5d0ee6d82fbd0 100644

--- a/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

+++ b/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

@@ -266,7 +266,7 @@ void InsertParagraphSeparatorCommand::doApply()

//---------------------------------------------------------------------

// Handle case when position is in the first visible position in its block, and

// similar case where previous position is in another, presumeably nested, block.

- if (isFirstInBlock || !inSameBlock(visiblePos, visiblePos.previous())) {

+ if (isFirstInBlock || !inSameBlock(visiblePos, previousPositionOf(visiblePos))) {

Node* refNode = nullptr;

insertionPosition = positionOutsideTabSpan(insertionPosition);

« no previous file with comments | « Source/core/editing/commands/InsertListCommand.cpp ('k') | Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »