Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131003004: Update platform classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), tommyw+watchlist_chromium.org, dsinclair, krit, jbroman, Raymond Toy, danakj, dstockwell, Timothy Loh, Rik, rwlbuis, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Visibility:
Public.

Description

Update platform classes to use OVERRIDE / FINAL when needed Update platform classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. To be safe, I did not FINALize any class marked as PLATFORM_EXPORT. R=eseidel, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -216 lines) Patch
M Source/platform/PODArena.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/PODIntervalTree.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/RefCountedSupplement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/SharedTimer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/Timer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/animation/AnimationValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/animation/TimingFunction.h View 7 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/audio/AudioDSPKernelProcessor.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/audio/AudioDelayDSPKernel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/audio/AudioDestination.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/audio/EqualPowerPanner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/SegmentedFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/DecodingImageGenerator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/DiscardablePixelRef.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStore.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/LazyDecodingPixelRef.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/image-decoders/bmp/BMPImageDecoder.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/ico/ICOImageDecoder.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.h View 2 chunks +23 lines, -23 lines 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/plugins/PluginListBuilder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/scroll/FramelessScrollView.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/scroll/ScrollView.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/scroll/Scrollbar.h View 4 chunks +40 lines, -40 lines 0 comments Download
M Source/platform/testing/ArenaTestHelpers.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/text/LineEnding.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/transforms/IdentityTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/InterpolatedTransformOperation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/Matrix3DTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/MatrixTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/PerspectiveTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/RotateTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/ScaleTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/SkewTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/transforms/TranslateTransformOperation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/weborigin/KURL.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 04:07:52 UTC) #1
eseidel
lgtm
6 years, 11 months ago (2014-01-11 04:11:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131003004/1
6 years, 11 months ago (2014-01-11 04:11:35 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 05:19:37 UTC) #4
Message was sent while issue was closed. 
Change committed as 164929

Powered by Google App Engine
This is Rietveld 408576698