[Background Sync] Allow sync manager access from uncontrolled clients

public/platform/modules/background_sync/WebSyncProvider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebSyncProvider_h
 #define WebSyncProvider_h
 
 #include "public/platform/WebCallbacks.h"
 #include "public/platform/WebCommon.h"
 #include "public/platform/WebString.h"
@@ skipping 11 matching lines @@
 using WebSyncUnregistrationCallbacks = WebCallbacks<bool*, WebSyncError*>;
 using WebSyncGetRegistrationsCallbacks = WebCallbacks<WebVector<WebSyncRegistration*>*, WebSyncError*>;
 using WebSyncGetPermissionStatusCallbacks = WebCallbacks<WebSyncPermissionStatus*, WebSyncError*>;
 
 class WebSyncProvider {
 public:
     virtual ~WebSyncProvider() { }
 
     // Takes ownership of the WebSyncRegistrationCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
-    virtual void registerBackgroundSync(const WebSyncRegistration*, WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) = 0;
+    // TODO(iclelland): Remove the body of this method once it is implemented in all subclasses.
+    virtual void registerBackgroundSync(const WebSyncRegistration* options, WebServiceWorkerRegistration* serviceWorkerRegistration, bool requestedFromServiceWorker, WebSyncRegistrationCallbacks* callbacks)
+    {
+        registerBackgroundSync(options, serviceWorkerRegistration, callbacks);
+    }
+
+    // TODO(iclelland): Remove this deprecated method once callers have switched to the 4-argument version.

[jkarlin, 2015/08/26 12:45:41]

The callers have already switched in this case. Perhaps rephrase to "once the
browser implements the 4-argument version".

[iclelland, 2015/09/02 17:10:37]

That is, of course, absolutely correct :) Thanks; done.

+    virtual void registerBackgroundSync(const WebSyncRegistration*, WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) { }
 
     // Takes ownership of the WebSyncUnregistrationCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void unregisterBackgroundSync(blink::WebSyncRegistration::Periodicity, int64_t, const WebString&, WebServiceWorkerRegistration*, WebSyncUnregistrationCallbacks*) = 0;
 
     // Takes ownership of the WebSyncRegistrationCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void getRegistration(blink::WebSyncRegistration::Periodicity, const WebString&, WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) = 0;
 
     // Takes ownership of the WebSyncGetRegistrationsCallbacks.
@@ skipping 22 matching lines @@
     virtual void releaseRegistration(int64_t syncId)
     {
         // TODO(jkarlin): After landing both legs of the releaseRegistration CLs, make this a pure virtual function.
         return;
     }
 };
 
 } // namespace blink
 
 #endif // WebSyncProvider_h