Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: Source/modules/background_sync/PeriodicSyncManager.cpp

Issue 1309393003: [Background Sync] Allow sync manager access from uncontrolled clients (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/background_sync/PeriodicSyncManager.cpp
diff --git a/Source/modules/background_sync/PeriodicSyncManager.cpp b/Source/modules/background_sync/PeriodicSyncManager.cpp
index 3d149c2d0284a40c62fff07113470fe83dac30dc..849acb7f7165fb05e28748128dbab5f6a42ea33c 100644
--- a/Source/modules/background_sync/PeriodicSyncManager.cpp
+++ b/Source/modules/background_sync/PeriodicSyncManager.cpp
@@ -52,11 +52,8 @@ unsigned long PeriodicSyncManager::minPossiblePeriod()
return kMinPossiblePeriod;
}
-ScriptPromise PeriodicSyncManager::registerFunction(ScriptState* scriptState, const PeriodicSyncRegistrationOptions& options)
+ScriptPromise PeriodicSyncManager::registerFunction(ScriptState* scriptState, ExecutionContext* context, const PeriodicSyncRegistrationOptions& options)
{
- if (!m_registration->active())
- return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Registration failed - no active Service Worker"));
-
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
@@ -84,16 +81,13 @@ ScriptPromise PeriodicSyncManager::registerFunction(ScriptState* scriptState, co
networkState,
powerState
);
- backgroundSyncProvider()->registerBackgroundSync(webSyncRegistration, m_registration->webRegistration(), new SyncRegistrationCallbacks(resolver, m_registration));
+ backgroundSyncProvider()->registerBackgroundSync(webSyncRegistration, m_registration->webRegistration(), context->isServiceWorkerGlobalScope(), new SyncRegistrationCallbacks(resolver, m_registration));
return promise;
}
ScriptPromise PeriodicSyncManager::getRegistration(ScriptState* scriptState, const String& syncRegistrationTag)
{
- if (!m_registration->active())
- return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));
-
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
@@ -104,9 +98,6 @@ ScriptPromise PeriodicSyncManager::getRegistration(ScriptState* scriptState, con
ScriptPromise PeriodicSyncManager::getRegistrations(ScriptState* scriptState)
{
- if (!m_registration->active())
- return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));
-
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
@@ -117,9 +108,6 @@ ScriptPromise PeriodicSyncManager::getRegistrations(ScriptState* scriptState)
ScriptPromise PeriodicSyncManager::permissionState(ScriptState* scriptState)
{
- if (!m_registration->active())
- return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "Operation failed - no active Service Worker"));
-
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
« no previous file with comments | « Source/modules/background_sync/PeriodicSyncManager.h ('k') | Source/modules/background_sync/PeriodicSyncManager.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698