Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1309323004: Create a NavigationEntry for the initial blank page.

Created:
5 years, 3 months ago by Charlie Reis
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a NavigationEntry for the initial blank page. This allows us to track subframe FrameNavigationEntries, eliminates corner cases, and avoids the need to ignore almost any navigations. BUG=524208 TEST=Can create an OOPIF on initial blank page in --site-per-process.

Patch Set 1 #

Patch Set 2 : Fix some tests #

Patch Set 3 : Fix title #

Patch Set 4 : Rebase #

Patch Set 5 : Fix content_unittests #

Patch Set 6 : Clean up title logic #

Patch Set 7 : Clean up and fix many tests #

Patch Set 8 : Move ignore to renderer #

Patch Set 9 : More test fixes #

Patch Set 10 : Rebase, fix more tests #

Patch Set 11 : Fix GetEntryCount, more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -195 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M components/favicon/content/content_favicon_driver.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M components/favicon/content/content_favicon_driver_unittest.cc View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M components/sessions/content/content_live_tab.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_live_tab.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/live_tab.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/tab_restore_service_helper.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_live_tab.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/ios/ios_live_tab.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher_browsertest.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 3 4 5 6 7 8 9 10 15 chunks +59 lines, -65 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 3 4 5 6 4 chunks +14 lines, -7 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 16 chunks +48 lines, -19 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 3 4 5 6 7 8 9 3 chunks +11 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +15 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 5 chunks +15 lines, -30 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -2 lines 0 comments Download
M content/public/browser/navigation_type.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698