Create a NavigationEntry for the initial blank page.

content/browser/frame_host/navigation_controller_impl_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/frame_host/frame_navigation_entry.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
@@ skipping 162 matching lines @@
 
 }  // namespace
 
 // When loading a new page to replace an old page in the history list, make sure
 // that the browser and renderer agree, and that both get it right.
 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
                        CorrectLengthWithCurrentItemReplacement) {
   NavigationController& controller =
       shell()->web_contents()->GetController();
 
+  // Before any navigation begins, we have one entry in the NavigationController
+  // for the initial about:blank, but the renderer thinks the history is empty.
+  // TODO(creis): Fix https://crbug.com/521729 and verify RendererHistoryLength
+  // is 0 before the first navigation.  (Or check in a popup.)
+  EXPECT_EQ(1, controller.GetEntryCount());
+
   EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,page1")));
   EXPECT_EQ(1, controller.GetEntryCount());
   EXPECT_EQ(1, RendererHistoryLength(shell()));
 
   EXPECT_TRUE(NavigateToURLAndReplace(shell(), GURL("data:text/html,page1a")));
   EXPECT_EQ(1, controller.GetEntryCount());
   EXPECT_EQ(1, RendererHistoryLength(shell()));
 
   // Now create two more entries and go back, to test replacing an entry without
   // pruning the forward history.
@@ skipping 61 matching lines @@
   void DidNavigateAnyFrame(RenderFrameHost* render_frame_host,
                            const LoadCommittedDetails& details,
                            const FrameNavigateParams& params) override {
     FAIL() << "No navigations should occur";
   }
 };
 
 }  // namespace
 
 // Some pages create a popup, then write an iframe into it. This causes a
-// subframe navigation without having any committed entry. Such navigations
-// just get thrown on the ground, but we shouldn't crash.
+// subframe navigation on the initial blank committed entry.
 //
-// This test actually hits NAVIGATION_TYPE_NAV_IGNORE three times. Two of them,
+// This test actually hits RendererDidNavigate three times. Two of them,
 // the initial window.open() and the iframe creation, don't try to create
 // navigation entries, and the third, the new navigation, tries to.
 IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest, SubframeOnEmptyPage) {
   NavigateToURL(shell(), GURL(url::kAboutBlankURL));
   EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
 
   FrameTreeNode* root =
       static_cast<WebContentsImpl*>(shell()->web_contents())->
           GetFrameTree()->root();
 
   // Pop open a new window.
   ShellAddedObserver new_shell_observer;
   std::string script = "window.open()";
   EXPECT_TRUE(content::ExecuteScript(root->current_frame_host(), script));
   Shell* new_shell = new_shell_observer.GetShell();
   ASSERT_NE(new_shell->web_contents(), shell()->web_contents());
   FrameTreeNode* new_root =
       static_cast<WebContentsImpl*>(new_shell->web_contents())->
           GetFrameTree()->root();
 
   // Make a new iframe in it.
+  // TODO(creis): This should actually navigate.
   NoNavigationsObserver observer(new_shell->web_contents());
   script = "var iframe = document.createElement('iframe');"
            "iframe.src = 'data:text/html,<p>some page</p>';"
            "document.body.appendChild(iframe);";
   EXPECT_TRUE(content::ExecuteScript(new_root->current_frame_host(), script));
   // The success check is of the last-committed entry, and there is none.
-  WaitForLoadStopWithoutSuccessCheck(new_shell->web_contents());
+  //WaitForLoadStopWithoutSuccessCheck(new_shell->web_contents());
+  WaitForLoadStop(new_shell->web_contents());
 
   ASSERT_EQ(1U, new_root->child_count());
   ASSERT_NE(nullptr, new_root->child_at(0));
 
   // Navigate it.
   GURL frame_url = embedded_test_server()->GetURL(
       "/navigation_controller/simple_page_2.html");
   script = "location.assign('" + frame_url.spec() + "')";
   EXPECT_TRUE(content::ExecuteScript(
       new_root->child_at(0)->current_frame_host(), script));
 
-  // Success is not crashing, and not navigating.
-  EXPECT_EQ(nullptr,
-            new_shell->web_contents()->GetController().GetLastCommittedEntry());
+  // TODO(creis): Should be able to go back.
+  // TODO(creis): This currently only works in --site-per-process.  I think it's
+  // because PageState might not get sent if page ID is -1?
 }
 
 namespace {
 
 class FrameNavigateParamsCapturer : public WebContentsObserver {
  public:
   // Observes navigation for the specified |node|.
   explicit FrameNavigateParamsCapturer(FrameTreeNode* node)
       : WebContentsObserver(
             node->current_frame_host()->delegate()->GetAsWebContents()),
@@ skipping 2086 matching lines @@
     EXPECT_EQ(original_url, capturer.all_params()[1].url);
     EXPECT_EQ(original_url, shell()->web_contents()->GetLastCommittedURL());
   }
 
   // Make sure the renderer is still alive.
   EXPECT_TRUE(
       ExecuteScript(shell()->web_contents(), "console.log('Success');"));
 }
 
 }  // namespace content