Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Issue 1309323004: Create a NavigationEntry for the initial blank page. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GetEntryCount, more tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
index ee0d4e58cd56b426658b3257cd6327009af6e8b8..fef1822bea690bae41be51464186fc67cb55fd14 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
@@ -289,18 +289,18 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, SuggestedFileName) {
ASSERT_EQ(kSuggestedFilename, base::UTF16ToUTF8(suggested_filename).c_str());
}
-// Ensure that View Page Info won't crash if there is no visible entry.
+// Ensure that View Page Info won't crash on the initial navigation.
// See http://crbug.com/370863.
-IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoWithNoEntry) {
- // Create a new tab with no committed entry.
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoOnInitialPage) {
+ // Create a new tab on the initial blank page.
ui_test_utils::WindowedTabAddedNotificationObserver tab_observer(
content::NotificationService::AllSources());
ASSERT_TRUE(content::ExecuteScript(
browser()->tab_strip_model()->GetActiveWebContents(), "window.open();"));
tab_observer.Wait();
content::WebContents* tab = tab_observer.GetTab();
- EXPECT_FALSE(tab->GetController().GetLastCommittedEntry());
- EXPECT_FALSE(tab->GetController().GetVisibleEntry());
+ EXPECT_TRUE(tab->GetController().IsInitialBlankNavigation());
+ EXPECT_TRUE(tab->GetController().GetVisibleEntry());
// Create a context menu.
content::ContextMenuParams context_menu_params;
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698