chrome/browser/sync/glue/synced_tab_delegate.cc - Issue 1309323004: Create a NavigationEntry for the initial blank page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/synced_tab_delegate.cc

Issue 1309323004: Create a NavigationEntry for the initial blank page. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GetEntryCount, more tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/synced_tab_delegate.cc

diff --git a/chrome/browser/sync/glue/synced_tab_delegate.cc b/chrome/browser/sync/glue/synced_tab_delegate.cc

index 4d51259eb35b355f52eced7faedcb3b0e8a9fae1..54fde076b003dca61875b86fb6f97668a7731ee2 100644

--- a/chrome/browser/sync/glue/synced_tab_delegate.cc

+++ b/chrome/browser/sync/glue/synced_tab_delegate.cc

@@ -36,10 +36,10 @@ bool SyncedTabDelegate::ShouldSync() const {

if (ProfileIsSupervised() && GetBlockedNavigations()->size() > 0)

return true;

- int entry_count = GetEntryCount();

- if (entry_count == 0)

+ if (IsInitialBlankNavigation())

return false; // This deliberately ignores a new pending entry.

+ int entry_count = GetEntryCount();

bool found_valid_url = false;

for (int i = 0; i < entry_count; ++i) {

const content::NavigationEntry* entry = GetEntryAtIndexMaybePending(i);