LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html - Issue 1309273007: Add requireInteraction to Notification & NotificationOptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

Issue 1309273007: Add requireInteraction to Notification & NotificationOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@constructor

Patch Set: Add to NotificationDataTest.cpp Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/notification-properties.html ('k') | LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

diff --git a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

index f44a63809992b766294359e115c8668f954c0f52..65b05607b6d325d6faeb1ab1fb2889a75cc8974b 100644

--- a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

+++ b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

@@ -28,6 +28,7 @@

icon: 'https://example/icon.png',

vibrate: [100, 200, 300],

silent: false,

+ requireInteraction: true,

data: [

{ property: 'foobar',

string: '\uDFFF\u0000\uDBFF',

@@ -70,6 +71,10 @@

options.actions = options.actions.slice(0, Notification.maxActions);

Object.keys(options).forEach(function(key) {

+ if (key == 'requireInteraction') {

+ // TODO(johnme): requireInteraction is not yet serialized properly.

+ return;

+ }

if (typeof options[key] == 'object')

assert_object_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');

else