Fix notifications tests' use of assert_object_equals

Fix notifications tests' use of assert_object_equals

Several notifications layout tests misues assert_object_equals, passing
in non-object values, and assuming it will behave like assert_equals.

Spoiler - it doesn't: assert_object_equals(true, false) passes!

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201317

[johnme, 2015-08-27 13:47:22]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-08-27 14:17:11]

lgtm % comment, thanks John!

https://codereview.chromium.org/1321643002/diff/1/LayoutTests/http/tests/noti...
File
LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html
(right):

https://codereview.chromium.org/1321643002/diff/1/LayoutTests/http/tests/noti...
LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html:68:
// TODO(peter): NaN should round trip to NaN rather than null.
Let's remove this clause and the NaN value test. We should not be testing
SerializedScriptValue, and certainly not have TODOs for bugs in that code here
:-).

https://codereview.chromium.org/1321643002/diff/1/LayoutTests/http/tests/noti...
LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html:75:
if (++pos < notificationDataList.length)
Why this change? I find this less readable.

[johnme, 2015-08-27 14:42:14]

Addressed review comments - thanks :)

https://codereview.chromium.org/1321643002/diff/1/LayoutTests/http/tests/noti...
File
LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html
(right):

https://codereview.chromium.org/1321643002/diff/1/LayoutTests/http/tests/noti...
LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html:68:
// TODO(peter): NaN should round trip to NaN rather than null.
On 2015/08/27 14:17:11, Peter Beverloo wrote:
> Let's remove this clause and the NaN value test. We should not be testing
> SerializedScriptValue, and certainly not have TODOs for bugs in that code here
> :-).

Done - filed https://crbug.com/525652.

https://codereview.chromium.org/1321643002/diff/1/LayoutTests/http/tests/noti...
LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html:75:
if (++pos < notificationDataList.length)
On 2015/08/27 14:17:11, Peter Beverloo wrote:
> Why this change? I find this less readable.

Because it fixes pos going out of bounds! [which was masked by
assert_object_equals(someobject, undefined) passing]

[johnme, 2015-08-27 14:42:17]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-08-27 14:42:17]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1321643002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2015-08-27 14:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321643002/20001

[commit-bot: I haz the power, 2015-08-27 15:25:26]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201317