Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1308053006: CC Animations: Enable external animation host for blink. (Closed)

Created:
5 years, 3 months ago by loyso (OOO)
Modified:
5 years ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Enable external animation host for blink. Depends on blink layout tests: https://codereview.chromium.org/1360233004/ Also, this will redirect impl-only scroll offset animations code (LayerTreeHostImpl::ScrollAnimationCreate/ScrollAnimationUpdateTarget) to cc::AnimationHost::scroll_offset_animations_ entity. BUG=394777 Committed: https://crrev.com/399f035cbbb4726b1a5fb3729d569dedaab7919e Cr-Commit-Position: refs/heads/master@{#352989} Fixes after it was reverted: http://crrev.com/1410873003 Fix isThreadedAnimationEnabled mode for layout tests http://crrev.com/1413003002 Fix AnimationHost mode integration with Property Trees. http://crrev.com/1409393005 Fix flaky unittest on Android. http://crrev.com/1413373007 Fix LinkHighlights detach scope. http://crrev.com/1420913008 Fix ProgrammaticScrollAnimator detach scope. webkit_unit_tests: http://crrev.com/1406163006 Composited Animations Tests: Support compositorAnimationTimelinesEnabled mode. http://crrev.com/1432783003 Graphics Layer Test: Support compositorAnimationTimelines mode. http://crrev.com/1456303002 Allow AnimationPlayers attached to layers but not attached to timelines/host to die w/o DCHECK http://crrev.com/1409393005 Fix draw properties invalidation on LAC destruction. http://crrev.com/1472723002 Fix LayerTreeHostTimelinesTestSetPotentiallyAnimatingOnLacDestruction flakiness. http://crrev.com/1459023002 Fix frame swapping tests in WebFrameTest.cpp Committed: https://crrev.com/8090a3857be78bbf76cf68703485d5d066669c16 Cr-Commit-Position: refs/heads/master@{#363461}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase. #

Patch Set 8 : Touch blink file to run webkit_tests. #

Patch Set 9 : Enable AnimationHost mode for WebLayerTreeViewImplForTesting. #

Patch Set 10 : Try harder. #

Patch Set 11 : Rebase. #

Patch Set 12 : Rebase. Restore whitespace_file.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/whitespace_file.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (15 generated)
loyso (OOO)
5 years, 3 months ago (2015-09-02 03:28:31 UTC) #2
piman
lgtm
5 years, 3 months ago (2015-09-02 18:09:54 UTC) #3
ajuma
Looks like at least some of the test failures are real ones. This patch itself ...
5 years, 3 months ago (2015-09-02 19:58:51 UTC) #4
loyso (OOO)
On 2015/09/02 19:58:51, ajuma wrote: > Looks like at least some of the test failures ...
5 years, 3 months ago (2015-09-23 05:06:55 UTC) #5
Ian Vollick
On 2015/09/23 05:06:55, loyso wrote: > On 2015/09/02 19:58:51, ajuma wrote: > > Looks like ...
5 years, 3 months ago (2015-09-24 01:12:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308053006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308053006/60001
5 years, 2 months ago (2015-10-07 23:08:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/129156) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-07 23:16:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308053006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308053006/100001
5 years, 2 months ago (2015-10-07 23:24:52 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-08 00:35:35 UTC) #15
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/399f035cbbb4726b1a5fb3729d569dedaab7919e Cr-Commit-Position: refs/heads/master@{#352989}
5 years, 2 months ago (2015-10-08 00:36:36 UTC) #16
sof
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1398713002/ by sigbjornf@opera.com. ...
5 years, 2 months ago (2015-10-08 08:21:17 UTC) #17
loyso (OOO)
jochen@chromium.org: I want to run webkit_tests by touching whitespace file. LGTM needed! Thanks!
5 years, 1 month ago (2015-10-26 05:21:08 UTC) #20
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-26 07:11:25 UTC) #21
jochen (gone - plz use gerrit)
On 2015/10/26 at 07:11:25, jochen wrote: > lgtm BTW, I prefer new cls for relanding
5 years, 1 month ago (2015-10-26 07:12:06 UTC) #22
loyso (OOO)
Enable external animation host for WebLayerTreeViewImplForTesting as well. PTAL!
5 years, 1 month ago (2015-11-04 02:26:05 UTC) #23
loyso (OOO)
On 2015/11/04 02:26:05, loyso wrote: > Enable external animation host for WebLayerTreeViewImplForTesting as well. > ...
5 years, 1 month ago (2015-11-04 06:37:40 UTC) #24
loyso (OOO)
On 2015/11/04 06:37:40, loyso wrote: > On 2015/11/04 02:26:05, loyso wrote: > > Enable external ...
5 years, 1 month ago (2015-11-19 05:06:12 UTC) #25
ajuma
On 2015/11/19 05:06:12, loyso wrote: > On 2015/11/04 06:37:40, loyso wrote: > > On 2015/11/04 ...
5 years, 1 month ago (2015-11-19 14:11:01 UTC) #26
loyso (OOO)
Blocked on this single CL: https://codereview.chromium.org/1459023002/
5 years, 1 month ago (2015-11-24 05:02:04 UTC) #27
loyso (OOO)
On 2015/11/24 05:02:04, loyso wrote: > Blocked on this single CL: https://codereview.chromium.org/1459023002/ Unblocked, but now ...
5 years ago (2015-12-04 05:18:09 UTC) #31
loyso (OOO)
Now blocked on this CL: https://codereview.chromium.org/1506673002/
5 years ago (2015-12-07 00:43:26 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308053006/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308053006/220001
5 years ago (2015-12-07 11:19:00 UTC) #35
commit-bot: I haz the power
Committed patchset #12 (id:220001)
5 years ago (2015-12-07 12:53:29 UTC) #37
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/8090a3857be78bbf76cf68703485d5d066669c16 Cr-Commit-Position: refs/heads/master@{#363461}
5 years ago (2015-12-07 12:54:13 UTC) #39
falken
On 2015/12/07 12:54:13, commit-bot: I haz the power wrote: > Patchset 12 (id:??) landed as ...
5 years ago (2015-12-08 01:34:10 UTC) #40
loyso (OOO)
5 years ago (2015-12-08 03:31:38 UTC) #41
Message was sent while issue was closed.
On 2015/12/08 01:34:10, falken wrote:
> On 2015/12/07 12:54:13, commit-bot: I haz the power wrote:
> > Patchset 12 (id:??) landed as
> > https://crrev.com/8090a3857be78bbf76cf68703485d5d066669c16
> > Cr-Commit-Position: refs/heads/master@{#363461}
> 
> This seems to break webkit_unit_tests for Nexus 4:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...

Fixed with this CL: https://codereview.chromium.org/1509013002

Powered by Google App Engine
This is Rietveld 408576698