Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1509013002: CC Animations: Fix ParameterizedWebFrameTests on Android N4 (Closed)

Created:
5 years ago by loyso (OOO)
Modified:
5 years ago
Reviewers:
pdr., Mike West, sky, dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Fix ParameterizedWebFrameTests on Android N4 We don't call WebView::willCloselayerTreeView as discussed here crrev.com/1459023002 BUG=567436 Committed: https://crrev.com/b9fec8ec6f02a64900de1489886604e4d6651214 Cr-Commit-Position: refs/heads/master@{#363704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
loyso (OOO)
PTAL, anyone? This is to fix ToT for N4.
5 years ago (2015-12-08 01:06:32 UTC) #3
dcheng
lgtm
5 years ago (2015-12-08 01:31:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509013002/1
5 years ago (2015-12-08 01:34:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 02:06:31 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-08 02:07:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9fec8ec6f02a64900de1489886604e4d6651214
Cr-Commit-Position: refs/heads/master@{#363704}

Powered by Google App Engine
This is Rietveld 408576698