Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1360233004: Composited Animations: Introduce pixel-ref layout tests. (Closed)

Created:
5 years, 2 months ago by loyso (OOO)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Composited Animations: Introduce pixel-ref layout tests. We get the animation to effectively start paused at the time fraction we care about. In order to test a number of time fractions with a single pixel result, we're creating a new element for each sample so we can check them simultaneously. Migrated from this blink CL: https://codereview.chromium.org/1270303002/ BUG=509482 Committed: https://crrev.com/fabe15e0f2bb2ae79e93b69828733018f5c41402 Cr-Commit-Position: refs/heads/master@{#352539}

Patch Set 1 #

Total comments: 36

Patch Set 2 : Address code review issues. #

Total comments: 8

Patch Set 3 : Clean up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+601 lines, -120 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js View 1 2 1 chunk +209 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js View 1 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js View 1 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/timing-function.js View 1 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/translate-rotate-scale.js View 1 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-rotate-zero-degrees.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-rotate-zero-degrees-expected.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-simple.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-simple-expected.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-timing-function.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-timing-function-expected.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale-expected.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
D third_party/WebKit/ManualTests/animation/compositor-animation-steps.html View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
loyso (OOO)
PTAL.
5 years, 2 months ago (2015-09-28 02:11:18 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js File third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js (right): https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js#newcode7 third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:7: this.next_sample_id = 1; Use camel cased variable names. It's ...
5 years, 2 months ago (2015-09-30 01:45:28 UTC) #3
Ian Vollick
On 2015/09/30 01:45:28, alancutter wrote: > https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js > File > third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js > (right): > > ...
5 years, 2 months ago (2015-09-30 21:38:36 UTC) #4
loyso (OOO)
https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js File third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js (right): https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js#newcode7 third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:7: this.next_sample_id = 1; On 2015/09/30 01:45:27, alancutter wrote: > ...
5 years, 2 months ago (2015-10-06 01:47:50 UTC) #5
alancutter (OOO until 2018)
lgtm with nits. https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js File third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js (right): https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js#newcode44 third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:44: var testId = 1; This is ...
5 years, 2 months ago (2015-10-06 03:42:49 UTC) #6
loyso (OOO)
https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js File third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js (right): https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js#newcode44 third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:44: var testId = 1; On 2015/10/06 03:42:49, alancutter wrote: ...
5 years, 2 months ago (2015-10-06 04:01:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360233004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360233004/40001
5 years, 2 months ago (2015-10-06 04:58:25 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-06 05:03:47 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 05:04:26 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fabe15e0f2bb2ae79e93b69828733018f5c41402
Cr-Commit-Position: refs/heads/master@{#352539}

Powered by Google App Engine
This is Rietveld 408576698