Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1506673002: CC Animations: Add Platform::current()->compositorSupport() for CompositorWorkerThreadTest (Closed)

Created:
5 years ago by loyso (OOO)
Modified:
5 years ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Add Platform::current()->compositorSupport() for CompositorWorkerThreadTest Otherwise it crashes. Blocks this CL: https://codereview.chromium.org/1308053006/ BUG=394777 Committed: https://crrev.com/db763ff56ce86d183e96c780d012382659536fe2 Cr-Commit-Position: refs/heads/master@{#363432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
loyso (OOO)
mlamouri@chromium.org: Please review changes in vollick@chromium.org: Please review changes in mkwst@chromium.org: Please review changes in
5 years ago (2015-12-07 00:41:35 UTC) #2
Ian Vollick
On 2015/12/07 00:41:35, loyso wrote: > mailto:mlamouri@chromium.org: Please review changes in > > mailto:vollick@chromium.org: Please ...
5 years ago (2015-12-07 00:48:07 UTC) #4
loyso (OOO)
On 2015/12/07 00:48:07, vollick wrote: > platform/ lgtm. modules/compositorworker/ - anyone, please?
5 years ago (2015-12-07 04:27:30 UTC) #5
Ian Vollick
On 2015/12/07 04:27:30, loyso wrote: > On 2015/12/07 00:48:07, vollick wrote: > > platform/ lgtm. ...
5 years ago (2015-12-07 04:29:32 UTC) #6
Mike West
LGTM.
5 years ago (2015-12-07 06:27:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506673002/1
5 years ago (2015-12-07 09:33:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 09:41:08 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db763ff56ce86d183e96c780d012382659536fe2 Cr-Commit-Position: refs/heads/master@{#363432}
5 years ago (2015-12-07 09:41:55 UTC) #13
mlamouri (slow - plz ping)
5 years ago (2015-12-07 10:15:57 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698