Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1307763003:
Get rid of VisibleSelection constructor with Range parameter (Closed)
|
Created:
5 years, 4 months ago by yosin_UTC9 Modified:
5 years, 4 months ago CC:
blink-reviews, dcheng, yoichio Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionGet rid of VisibleSelection constructor with Range parameter
This patch gets rid of |VisibleSelection| constructor with |Range| parameter
to templatize |VisibleSelection| easier.
This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002
BUG=513568
TEST=n/a; No behavior changes
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201101
Patch Set 1 #
Messages
Total messages: 35 (16 generated)
yosin@chromium.org changed reviewers: + tkent@chromium.org
PTAL
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2015/08/24 at 14:19:47, commit-bot wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) See http://crbug.com/523598 for mac_chromium_rel_ng trouble.
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201101 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
